[PATCH 0/2] make PCIe DMA work on Broadcom BCM2711
Md Rayhanul Islam
r97yhan at gmail.com
Thu Sep 24 21:22:20 CEST 2026
Hello,
Thank you for the detailed review. I am reworking the series as an RFC for
the EAL DMA API and PCI bus hook, with igb as the first user.
DMA properties now come from each device’s host bridge, and cache handling
is in EAL. I will also revise RX buffer reuse, TX completion, and
descriptor ownership, and add separate burst functions for non-coherent DMA.
I will also remove the extra guide and shorten the comments.
Best regards,
Rayhan
On Mon, Sep 21, 2026 at 11:42 AM Stephen Hemminger <
stephen at networkplumber.org> wrote:
> On Mon, 21 Sep 2026 09:56:17 +0100
> Bruce Richardson <bruce.richardson at intel.com> wrote:
>
> > >
> > > Short observations:
> > > 1. Too much AI generated slop, extra docs, comments on everything.
> > > New code should look like the surrounding code.
> > > This looks like AI wasn't quite sure and left lots of docs for
> future self.
> >
> > I really don't view this as a bad thing. A little too much detail in the
> > comments is better for the future than too little. Given these patches
> > touch areas outside the usual behaviour we expect from DPDK platforms,
> > having extra comments is definitely useful.
> >
> >
> > /Bruce
>
> There is a fine line between a couple of sentences and three paragraphs
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mails.dpdk.org/archives/dev/attachments/20260924/a95cee60/attachment.htm>
More information about the dev
mailing list