Pull request feedback ignored

[Morten Brørup]

> From: Robin Jarry [mailto:rjarry at redhat.com]
> Sent: Saturday, 3 October 2026 11.49

Hi Robin,

Thanks for the quick response!

> 
> Hey Morten,
> 
> Morten Brørup, Oct 03, 2026 at 10:56:
> > I added some comments to https://github.com/DPDK/grout/pull/758, but
> > my feedback was ignored, and the series was merged anyway.
> 
> I don't see any comment from you on this pull request. Probably you
> didn't validate/submit your review?

Aha! That's what I missed.

> 
> > It's perfectly acceptable to disagree with feedback, or not consider
> > the suggestions worth the effort. That's not what this email is
> about.
> 
> It is *not* acceptable to ignore review feedback, I would have
> responded
> if I had seen your review. What were your concerns?

OK; I missed submitting them, so I won't blame you for not reacting. :-)

I suggested using the new high-res clock instead of the TSC.

I didn't elaborate, but using rdtsc() not provide higher accuracy than clock_ns():
The clock_ns() timestamp is taken when then graph burst processing starts.
The rdtsc() timestamp is taken when the individual packet is processed for capturing.
None of these timestamps are taken when the packet actually arrived on the wire to the NIC (at RX), or when the packet was sent on the wire by the NIC (at TX).

The per-packet rdtsc() calls have a performance cost in the datapath, and the conversion from TSC to nanoseconds adds unnecessary complexity to post-processing of the captured packets.

> 
> > Being new to the Github workflow, I'm concerned I didn't follow the
> > correct procedure... I didn't get any response to my feedback, so it
> > looks like it was completely missed. What did I do wrong?
> 
> See
> https://docs.github.com/en/pull-requests/how-tos/review-pull-
> requests/reviewing-proposed-changes-in-a-pull-request
> for more details.
> 
> They don't insist on the fact that none of your review comments will be
> visible to others until you "submit" your review.

OK. Thank you for guidance on the process/tools.

I have clicked the "Submit Review" button for my comments to the https://github.com/DPDK/grout/pull/742; let me know if they are still not visible.

-Morten