Pull request feedback ignored

[Robin Jarry]

Hey Morten,

Morten Brørup, Oct 03, 2026 at 10:56:
> I added some comments to https://github.com/DPDK/grout/pull/758, but
> my feedback was ignored, and the series was merged anyway.

I don't see any comment from you on this pull request. Probably you
didn't validate/submit your review?

> It's perfectly acceptable to disagree with feedback, or not consider
> the suggestions worth the effort. That's not what this email is about.

It is *not* acceptable to ignore review feedback, I would have responded
if I had seen your review. What were your concerns?

> Being new to the Github workflow, I'm concerned I didn't follow the
> correct procedure... I didn't get any response to my feedback, so it
> looks like it was completely missed. What did I do wrong?

See
https://docs.github.com/en/pull-requests/how-tos/review-pull-requests/reviewing-proposed-changes-in-a-pull-request
for more details.

They don't insist on the fact that none of your review comments will be
visible to others until you "submit" your review.

-- 
Robin

# Sanitized for your protection.