Pull request feedback ignored

[Morten Brørup]

Hi Robin,

 

I added some comments to https://github.com/DPDK/grout/pull/758, but my feedback was ignored, and the series was merged anyway.

 

It's perfectly acceptable to disagree with feedback, or not consider the suggestions worth the effort. That's not what this email is about.

Being new to the Github workflow, I'm concerned I didn't follow the correct procedure... I didn't get any response to my feedback, so it looks like it was completely missed. What did I do wrong?

 

For testing purposes, I have now added some comments to https://github.com/DPDK/grout/pull/742

 

 

Venlig hilsen / Kind regards,

-Morten Brørup

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mails.dpdk.org/archives/grout/attachments/20261003/dc5bc074/attachment.htm>