[dpdk-test-report] |WARNING| pw27375 [PATCH v1 09/21] net/mlx5: separate DPDK from Verbs Tx queue objects

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Aug 2 16:12:04 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27375

_coding style issues_


ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#33: FILE: drivers/net/mlx5/mlx5.c:208:
+		WARN("%p: some Verbs Tx queue still remain", (void*)priv);

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#81: FILE: drivers/net/mlx5/mlx5_rxtx.h:345:
+struct mlx5_txq_ibv* mlx5_priv_txq_ibv_new(struct priv *priv, uint16_t idx);

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#82: FILE: drivers/net/mlx5/mlx5_rxtx.h:346:
+struct mlx5_txq_ibv* mlx5_priv_txq_ibv_get(struct priv *priv, uint16_t idx);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#190: FILE: drivers/net/mlx5/mlx5_txq.c:173:
+		return ENOTSUP;

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#457: FILE: drivers/net/mlx5/mlx5_txq.c:454:
+		 * TX burst. */

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#536: FILE: drivers/net/mlx5/mlx5_txq.c:533:
+
+}

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EBUSY)
#583: FILE: drivers/net/mlx5/mlx5_txq.c:580:
+	return EBUSY;

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#616: FILE: drivers/net/mlx5/mlx5_txq.c:613:
+		DEBUG("%p: Verbs Tx queue %p still referenced", (void*)priv,

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#617: FILE: drivers/net/mlx5/mlx5_txq.c:614:
+		      (void*)txq);

total: 5 errors, 3 warnings, 1 checks, 570 lines checked


More information about the test-report mailing list