[dpdk-test-report] |WARNING| pw27376 [PATCH v1 10/21] net/mlx5: add reference counter on DPDK Tx queues

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Aug 2 16:12:06 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27376

_coding style issues_


ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#55: FILE: drivers/net/mlx5/mlx5.c:202:
+		WARN("%p: some Tx Queues still remain", (void*)priv);

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#169: FILE: drivers/net/mlx5/mlx5_rxtx.h:350:
+struct mlx5_txq_ctrl* mlx5_priv_txq_new(struct priv *priv, uint16_t idx,

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#171: FILE: drivers/net/mlx5/mlx5_rxtx.h:352:
+struct mlx5_txq_ctrl* mlx5_priv_txq_get(struct priv *priv, uint16_t idx);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#174: FILE: drivers/net/mlx5/mlx5_rxtx.h:355:
+int mlx5_priv_txq_verify(struct priv *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_mempool *' should also have an identifier name
#184: FILE: drivers/net/mlx5/mlx5_rxtx.h:384:
+void mlx5_mp2mr_iter(struct rte_mempool *, void *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'void *' should also have an identifier name
#184: FILE: drivers/net/mlx5/mlx5_rxtx.h:384:
+void mlx5_mp2mr_iter(struct rte_mempool *, void *);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EBUSY)
#676: FILE: drivers/net/mlx5/mlx5_txq.c:654:
+	return EBUSY;

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#716: FILE: drivers/net/mlx5/mlx5_txq.c:694:
+		DEBUG("%p: Tx Queue %p still referenced", (void*)priv,

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#717: FILE: drivers/net/mlx5/mlx5_txq.c:695:
+		      (void*)txq);

total: 5 errors, 4 warnings, 0 checks, 652 lines checked


More information about the test-report mailing list