[dpdk-test-report] |WARNING| pw37429 [PATCH 1/7] net/sfc/base: add a new means to control RSS hash

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Apr 6 19:22:54 CEST 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/37429

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#191: FILE: drivers/net/sfc/base/efx.h:2177:
+extern	__checkReturn				efx_rc_t

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_entryp' - possible side-effects?
#224: FILE: drivers/net/sfc/base/efx_rx.c:312:
+#define	LIST_FLAGS(_entryp, _class, _l4_hashing)			\
+	do {								\
+		if (_l4_hashing)					\
+			*(_entryp++) = EFX_RX_HASH(_class, 4TUPLE);	\
+									\
+		*(_entryp++) = EFX_RX_HASH(_class, 2TUPLE);		\
+		*(_entryp++) = EFX_RX_HASH(_class, DISABLE);		\
+									\
+		_NOTE(CONSTANTCONDITION)				\
+	} while (B_FALSE)

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_class' - possible side-effects?
#224: FILE: drivers/net/sfc/base/efx_rx.c:312:
+#define	LIST_FLAGS(_entryp, _class, _l4_hashing)			\
+	do {								\
+		if (_l4_hashing)					\
+			*(_entryp++) = EFX_RX_HASH(_class, 4TUPLE);	\
+									\
+		*(_entryp++) = EFX_RX_HASH(_class, 2TUPLE);		\
+		*(_entryp++) = EFX_RX_HASH(_class, DISABLE);		\
+									\
+		_NOTE(CONSTANTCONDITION)				\
+	} while (B_FALSE)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#253: FILE: drivers/net/sfc/base/efx_rx.c:341:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#261: FILE: drivers/net/sfc/base/efx_rx.c:349:
+	return (rc);

total: 2 errors, 0 warnings, 3 checks, 320 lines checked


More information about the test-report mailing list