[dpdk-test-report] |WARNING| pw37430 [PATCH 2/7] net/sfc/base: support more RSS hash configurations
checkpatch at dpdk.org
checkpatch at dpdk.org
Fri Apr 6 19:22:55 CEST 2018
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/37430
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_entryp' - possible side-effects?
#203: FILE: drivers/net/sfc/base/efx_rx.c:316:
+#define LIST_FLAGS(_entryp, _class, _l4_hashing, _additional_modes) \
do { \
+ if (_l4_hashing) { \
*(_entryp++) = EFX_RX_HASH(_class, 4TUPLE); \
\
+ if (_additional_modes) { \
+ *(_entryp++) = \
+ EFX_RX_HASH(_class, 2TUPLE_DST); \
+ *(_entryp++) = \
+ EFX_RX_HASH(_class, 2TUPLE_SRC); \
+ } \
+ } \
+ \
*(_entryp++) = EFX_RX_HASH(_class, 2TUPLE); \
+ \
+ if (_additional_modes) { \
+ *(_entryp++) = EFX_RX_HASH(_class, 1TUPLE_DST); \
+ *(_entryp++) = EFX_RX_HASH(_class, 1TUPLE_SRC); \
+ } \
+ \
*(_entryp++) = EFX_RX_HASH(_class, DISABLE); \
\
_NOTE(CONSTANTCONDITION) \
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_class' - possible side-effects?
#203: FILE: drivers/net/sfc/base/efx_rx.c:316:
+#define LIST_FLAGS(_entryp, _class, _l4_hashing, _additional_modes) \
do { \
+ if (_l4_hashing) { \
*(_entryp++) = EFX_RX_HASH(_class, 4TUPLE); \
\
+ if (_additional_modes) { \
+ *(_entryp++) = \
+ EFX_RX_HASH(_class, 2TUPLE_DST); \
+ *(_entryp++) = \
+ EFX_RX_HASH(_class, 2TUPLE_SRC); \
+ } \
+ } \
+ \
*(_entryp++) = EFX_RX_HASH(_class, 2TUPLE); \
+ \
+ if (_additional_modes) { \
+ *(_entryp++) = EFX_RX_HASH(_class, 1TUPLE_DST); \
+ *(_entryp++) = EFX_RX_HASH(_class, 1TUPLE_SRC); \
+ } \
+ \
*(_entryp++) = EFX_RX_HASH(_class, DISABLE); \
\
_NOTE(CONSTANTCONDITION) \
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_additional_modes' - possible side-effects?
#203: FILE: drivers/net/sfc/base/efx_rx.c:316:
+#define LIST_FLAGS(_entryp, _class, _l4_hashing, _additional_modes) \
do { \
+ if (_l4_hashing) { \
*(_entryp++) = EFX_RX_HASH(_class, 4TUPLE); \
\
+ if (_additional_modes) { \
+ *(_entryp++) = \
+ EFX_RX_HASH(_class, 2TUPLE_DST); \
+ *(_entryp++) = \
+ EFX_RX_HASH(_class, 2TUPLE_SRC); \
+ } \
+ } \
+ \
*(_entryp++) = EFX_RX_HASH(_class, 2TUPLE); \
+ \
+ if (_additional_modes) { \
+ *(_entryp++) = EFX_RX_HASH(_class, 1TUPLE_DST); \
+ *(_entryp++) = EFX_RX_HASH(_class, 1TUPLE_SRC); \
+ } \
+ \
*(_entryp++) = EFX_RX_HASH(_class, DISABLE); \
\
_NOTE(CONSTANTCONDITION) \
total: 0 errors, 0 warnings, 3 checks, 197 lines checked
More information about the test-report
mailing list