[dpdk-test-report] |WARNING| pw44412 [17/21] net/atlantic: device statistics, xstats

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Sep 7 17:25:02 CEST 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/44412

_coding style issues_


ERROR:CODE_INDENT: code indent should use tabs where possible
#39: FILE: drivers/net/atlantic/atl_ethdev.c:70:
+                                struct rte_eth_xstat *stats, unsigned int n);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#39: FILE: drivers/net/atlantic/atl_ethdev.c:70:
+                                struct rte_eth_xstat *stats, unsigned int n);$

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#115: FILE: drivers/net/atlantic/atl_ethdev.c:752:
+	unsigned i;

WARNING:LONG_LINE: line over 90 characters
#153: FILE: drivers/net/atlantic/atl_ethdev.c:790:
+atl_dev_xstats_get_names(struct rte_eth_dev *dev __rte_unused, struct rte_eth_xstat_name *xstats_names, unsigned int size)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#172: FILE: drivers/net/atlantic/atl_ethdev.c:809:
+	unsigned i;

WARNING:LONG_LINE: line over 90 characters
#179: FILE: drivers/net/atlantic/atl_ethdev.c:816:
+		stats[i].value = *(u64 *)((uint8_t *)&hw->curr_stats + atl_xstats_tbl[i].offset);

WARNING:RETURN_VOID: void function return statements are not generally useful
#189: FILE: drivers/net/atlantic/atl_ethdev.c:826:
+	return;
+}

total: 1 errors, 6 warnings, 0 checks, 161 lines checked


More information about the test-report mailing list