[dpdk-test-report] |WARNING| pw44413 [18/21] net/atlantic: VLAN filters and offloads

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Sep 7 17:25:03 CEST 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/44413

_coding style issues_


WARNING:LONG_LINE: line over 90 characters
#41: FILE: drivers/net/atlantic/atl_ethdev.c:95:
+static int atl_vlan_tpid_set(struct rte_eth_dev *dev, enum rte_vlan_type vlan_type, uint16_t tpid);

WARNING:LONG_LINE_COMMENT: line over 90 characters
#107: FILE: drivers/net/atlantic/atl_ethdev.c:1286:
+		goto exit; /* VLAN_ID already exist, or already removed above. Nothing to do. */

ERROR:CODE_INDENT: code indent should use tabs where possible
#128: FILE: drivers/net/atlantic/atl_ethdev.c:1307:
+        for (i = 0; i < HW_ATL_B0_MAX_VLAN_IDS; i++) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#128: FILE: drivers/net/atlantic/atl_ethdev.c:1307:
+        for (i = 0; i < HW_ATL_B0_MAX_VLAN_IDS; i++) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#129: FILE: drivers/net/atlantic/atl_ethdev.c:1308:
+                if (cfg->vlan_filter[i] != 0)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#129: FILE: drivers/net/atlantic/atl_ethdev.c:1308:
+                if (cfg->vlan_filter[i] != 0)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#130: FILE: drivers/net/atlantic/atl_ethdev.c:1309:
+                        break;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#130: FILE: drivers/net/atlantic/atl_ethdev.c:1309:
+                        break;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#131: FILE: drivers/net/atlantic/atl_ethdev.c:1310:
+        }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#131: FILE: drivers/net/atlantic/atl_ethdev.c:1310:
+        }$

WARNING:BRACES: braces {} are not necessary for single statement blocks
#148: FILE: drivers/net/atlantic/atl_ethdev.c:1327:
+		if (cfg->vlan_filter[i]) {
+			hw_atl_rpf_vlan_flr_en_set(hw, en, i);
+		}

ERROR:TRAILING_WHITESPACE: trailing whitespace
#155: FILE: drivers/net/atlantic/atl_ethdev.c:1334:
+static int $

WARNING:BRACES: braces {} are not necessary for single statement blocks
#169: FILE: drivers/net/atlantic/atl_ethdev.c:1348:
+	for (i = 0; i < dev->data->nb_rx_queues; i++) {
+		hw_atl_rpo_rx_desc_vlan_stripping_set(hw, cfg->vlan_strip, i);
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#173: FILE: drivers/net/atlantic/atl_ethdev.c:1352:
+	if (mask & ETH_VLAN_EXTEND_MASK) {
+		ret = -ENOTSUP;
+	} 

ERROR:TRAILING_WHITESPACE: trailing whitespace
#175: FILE: drivers/net/atlantic/atl_ethdev.c:1354:
+^I} $

total: 6 errors, 9 warnings, 0 checks, 186 lines checked


More information about the test-report mailing list