[dpdk-test-report] |WARNING| pw44414 [19/21] net/atlantic: device MTU and statuses

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/44414

_coding style issues_


ERROR:SPACING: space prohibited after that open parenthesis '('
#58: FILE: drivers/net/atlantic/atl_ethdev.c:198:
+#define ATL_RX_OFFLOADS ( DEV_RX_OFFLOAD_VLAN_STRIP \

ERROR:SPACING: space prohibited after that open parenthesis '('
#65: FILE: drivers/net/atlantic/atl_ethdev.c:205:
+#define ATL_TX_OFFLOADS ( DEV_TX_OFFLOAD_VLAN_INSERT \

WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'atl_dev_start', this function's name, in a string
#92: FILE: drivers/net/atlantic/atl_ethdev.c:686:
+	PMD_INIT_LOG(ERR, "failure in atl_dev_start(): %d", err);

WARNING:LONG_LINE: line over 90 characters
#113: FILE: drivers/net/atlantic/atl_ethdev.c:880:
+	ret = snprintf(fw_version, fw_size, "%u.%u.%u", fw_ver >> 24, (fw_ver >> 16) & 0xFFU, fw_ver & 0xFFFFU);

CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#156: FILE: drivers/net/atlantic/atl_ethdev.c:923:
+	dev_info->hash_key_size = HW_ATL_B0_RSS_HASHKEY_BITS/8;
 	                                                    ^

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mtu < ETHER_MIN_MTU'
#218: FILE: drivers/net/atlantic/atl_ethdev.c:1395:
+	if ((mtu < ETHER_MIN_MTU) || (frame_size > dev_info.max_rx_pktlen))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'frame_size > dev_info.max_rx_pktlen'
#218: FILE: drivers/net/atlantic/atl_ethdev.c:1395:
+	if ((mtu < ETHER_MIN_MTU) || (frame_size > dev_info.max_rx_pktlen))

total: 2 errors, 2 warnings, 3 checks, 210 lines checked