[dpdk-test-report] |WARNING| pw44415 [20/21] net/atlantic: RX side structures and implementation

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Sep 7 17:28:26 CEST 2018
Previous message: [dpdk-test-report] |WARNING| pw44414 [19/21] net/atlantic: device MTU and statuses
Next message: [dpdk-test-report] |WARNING| pw44416 [21/21] net/atlantic: TX side structures and implementation
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/44415

_coding style issues_


ERROR:INLINE_LOCATION: inline keyword should sit between storage class and type
#321: FILE: drivers/net/atlantic/atl_rxtx.c:75:
+inline static void

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#324: FILE: drivers/net/atlantic/atl_rxtx.c:78:
+	struct hw_atl_rxd_s * rxd = NULL;

WARNING:LONG_LINE: line over 90 characters
#353: FILE: drivers/net/atlantic/atl_rxtx.c:107:
+		"greater than or equal to %d", AQ_HW_MAX_RX_RING_SIZE, AQ_HW_MIN_RX_RING_SIZE);

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#358: FILE: drivers/net/atlantic/atl_rxtx.c:112:
+	/*
+	* if this queue existed already, free the associated memory. The

WARNING:LONG_LINE: line over 90 characters
#368: FILE: drivers/net/atlantic/atl_rxtx.c:122:
+	rxq = rte_zmalloc_socket("atlantic Rx queue", sizeof(*rxq), RTE_CACHE_LINE_SIZE, socket_id);

WARNING:LONG_LINE: line over 90 characters
#381: FILE: drivers/net/atlantic/atl_rxtx.c:135:
+	rxq->l3_csum_enabled = dev->data->dev_conf.rxmode.offloads & DEV_RX_OFFLOAD_IPV4_CKSUM;

ERROR:SPACING: spaces required around that '=' (ctx:WxV)
#430: FILE: drivers/net/atlantic/atl_rxtx.c:184:
+	for (i =0 ; i < eth_dev->data->nb_rx_queues; i++) {
 	       ^

WARNING:LONG_LINE_COMMENT: line over 90 characters
#434: FILE: drivers/net/atlantic/atl_rxtx.c:188:
+		/* Take requested pool mbuf size and adapt descriptor buffer to best fit */

WARNING:LONG_LINE: line over 90 characters
#440: FILE: drivers/net/atlantic/atl_rxtx.c:194:
+			PMD_INIT_LOG(WARNING, "queue %d: mem pool buff size is larger than max supported
", rxq->queue_id);

WARNING:LONG_LINE: line over 90 characters
#444: FILE: drivers/net/atlantic/atl_rxtx.c:198:
+			PMD_INIT_LOG(ERR, "queue %d: mem pool buff size is too small
", rxq->queue_id);

WARNING:LONG_LINE: line over 90 characters
#449: FILE: drivers/net/atlantic/atl_rxtx.c:203:
+		err = hw_atl_b0_hw_ring_rx_init(hw, base_addr, rxq->queue_id, rxq->nb_rx_desc, buff_size, 0, rxq->port_id);

WARNING:LONG_LINE: line over 90 characters
#473: FILE: drivers/net/atlantic/atl_rxtx.c:227:
+			PMD_INIT_LOG(ERR, "mbuf alloca failed for rx queue %u", (unsigned)rxq->queue_id);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#473: FILE: drivers/net/atlantic/atl_rxtx.c:227:
+			PMD_INIT_LOG(ERR, "mbuf alloca failed for rx queue %u", (unsigned)rxq->queue_id);

WARNING:LONG_LINE: line over 90 characters
#519: FILE: drivers/net/atlantic/atl_rxtx.c:273:
+			PMD_INIT_LOG(ERR, "Allocate mbufs for queue %d failed", rx_queue_id);

CHECK:SPACING: spaces preferred around that '-' (ctx:WxV)
#526: FILE: drivers/net/atlantic/atl_rxtx.c:280:
+		hw_atl_reg_rx_dma_desc_tail_ptr_set(hw, rxq->nb_rx_desc -1, rx_queue_id);
 		                                                        ^

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#576: FILE: drivers/net/atlantic/atl_rxtx.c:330:
+	unsigned i;

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#586: FILE: drivers/net/atlantic/atl_rxtx.c:340:
+
+}

WARNING:LONG_LINE: line over 90 characters
#623: FILE: drivers/net/atlantic/atl_rxtx.c:377:
+atl_rxq_info_get(struct rte_eth_dev *dev, uint16_t queue_id, struct rte_eth_rxq_info *qinfo)

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#762: FILE: drivers/net/atlantic/atl_rxtx.c:516:
+		if (rxd_wb->rx_stat & BIT(2)) {
[...]
+		} else {
[...]

ERROR:TRAILING_WHITESPACE: trailing whitespace
#770: FILE: drivers/net/atlantic/atl_rxtx.c:524:
+^I^I$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#814: FILE: drivers/net/atlantic/atl_rxtx.c:568:
+^Ireturn type;^I^I$

CHECK:SPACING: No space is necessary after a cast
#849: FILE: drivers/net/atlantic/atl_rxtx.c:603:
+			   (unsigned)rxq->port_id, (unsigned) rxq->queue_id,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#849: FILE: drivers/net/atlantic/atl_rxtx.c:603:
+			   (unsigned)rxq->port_id, (unsigned) rxq->queue_id,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#849: FILE: drivers/net/atlantic/atl_rxtx.c:603:
+			   (unsigned)rxq->port_id, (unsigned) rxq->queue_id,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#850: FILE: drivers/net/atlantic/atl_rxtx.c:604:
+			   (unsigned)tail, (unsigned)rxd_wb.eop,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#850: FILE: drivers/net/atlantic/atl_rxtx.c:604:
+			   (unsigned)tail, (unsigned)rxd_wb.eop,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#851: FILE: drivers/net/atlantic/atl_rxtx.c:605:
+			   (unsigned)rte_le_to_cpu_16(rxd_wb.pkt_len),

ERROR:SPACING: space required before the open parenthesis '('
#856: FILE: drivers/net/atlantic/atl_rxtx.c:610:
+			while(true) {

CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#859: FILE: drivers/net/atlantic/atl_rxtx.c:613:
+				eop_tail = (eop_tail+1) % rxq->nb_rx_desc;
 				                    ^

WARNING:LONG_LINE: line over 90 characters
#860: FILE: drivers/net/atlantic/atl_rxtx.c:614:
+				eop_rxwbd = (struct hw_atl_rxd_wb_s*)&rxq->hw_ring[eop_tail];

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#860: FILE: drivers/net/atlantic/atl_rxtx.c:614:
+				eop_rxwbd = (struct hw_atl_rxd_wb_s*)&rxq->hw_ring[eop_tail];

CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#873: FILE: drivers/net/atlantic/atl_rxtx.c:627:
+		rx_mbuf_prev = rx_mbuf_first = NULL;

ERROR:SPACING: space required before the open parenthesis '('
#876: FILE: drivers/net/atlantic/atl_rxtx.c:630:
+		while(true) {

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#877: FILE: drivers/net/atlantic/atl_rxtx.c:631:
+		while(true) {
+

CHECK:SPACING: No space is necessary after a cast
#881: FILE: drivers/net/atlantic/atl_rxtx.c:635:
+						   "queue_id=%u", (unsigned) rxq->port_id,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#881: FILE: drivers/net/atlantic/atl_rxtx.c:635:
+						   "queue_id=%u", (unsigned) rxq->port_id,

CHECK:SPACING: No space is necessary after a cast
#882: FILE: drivers/net/atlantic/atl_rxtx.c:636:
+						   (unsigned) rxq->queue_id);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#882: FILE: drivers/net/atlantic/atl_rxtx.c:636:
+						   (unsigned) rxq->queue_id);

WARNING:LONG_LINE: line over 90 characters
#926: FILE: drivers/net/atlantic/atl_rxtx.c:680:
+										rxq->buff_size : pkt_len;

WARNING:LONG_LINE_COMMENT: line over 90 characters
#935: FILE: drivers/net/atlantic/atl_rxtx.c:689:
+			//pkt_flags = rx_desc_hlen_type_rss_to_pkt_flags(rxq, hlen_type_rss);

CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#948: FILE: drivers/net/atlantic/atl_rxtx.c:702:
+			tail = (tail+1) % rxq->nb_rx_desc;
 			            ^

WARNING:BRACES: braces {} are not necessary for single statement blocks
#957: FILE: drivers/net/atlantic/atl_rxtx.c:711:
+			if (rxd_wb.eop) {
+				break;
+			}

WARNING:LONG_LINE: line over 90 characters
#972: FILE: drivers/net/atlantic/atl_rxtx.c:726:
+		PMD_RX_LOG(ERR, "add mbuf segs=%d pkt_len=%d", rx_mbuf_first->nb_segs, rx_mbuf_first->pkt_len);

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#980: FILE: drivers/net/atlantic/atl_rxtx.c:734:
+	/*
+	* If the number of free RX descriptors is greater than the RX free

CHECK:SPACING: No space is necessary after a cast
#988: FILE: drivers/net/atlantic/atl_rxtx.c:742:
+	nb_hold = (uint16_t) (nb_hold + rxq->nb_rx_hold);

CHECK:SPACING: No space is necessary after a cast
#992: FILE: drivers/net/atlantic/atl_rxtx.c:746:
+			(unsigned) rxq->port_id, (unsigned) rxq->queue_id,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#992: FILE: drivers/net/atlantic/atl_rxtx.c:746:
+			(unsigned) rxq->port_id, (unsigned) rxq->queue_id,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#992: FILE: drivers/net/atlantic/atl_rxtx.c:746:
+			(unsigned) rxq->port_id, (unsigned) rxq->queue_id,

CHECK:SPACING: No space is necessary after a cast
#993: FILE: drivers/net/atlantic/atl_rxtx.c:747:
+			(unsigned) tail, (unsigned) nb_hold, (unsigned) nb_rx);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#993: FILE: drivers/net/atlantic/atl_rxtx.c:747:
+			(unsigned) tail, (unsigned) nb_hold, (unsigned) nb_rx);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#993: FILE: drivers/net/atlantic/atl_rxtx.c:747:
+			(unsigned) tail, (unsigned) nb_hold, (unsigned) nb_rx);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#993: FILE: drivers/net/atlantic/atl_rxtx.c:747:
+			(unsigned) tail, (unsigned) nb_hold, (unsigned) nb_rx);

CHECK:SPACING: No space is necessary after a cast
#994: FILE: drivers/net/atlantic/atl_rxtx.c:748:
+		tail = (uint16_t) ((tail == 0) ? (rxq->nb_rx_desc - 1) : (tail - 1));

total: 8 errors, 32 warnings, 13 checks, 963 lines checked
Previous message: [dpdk-test-report] |WARNING| pw44414 [19/21] net/atlantic: device MTU and statuses
Next message: [dpdk-test-report] |WARNING| pw44416 [21/21] net/atlantic: TX side structures and implementation
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list