[dpdk-test-report] |WARNING| pw68734 [PATCH 2/3] net/octeontx2: add tm packet marking cb

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Apr 17 09:24:23 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/68734

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#213: FILE: drivers/net/octeontx2/otx2_tm.c:402:
+		    "adjust 0x%" PRIx64 "(pktmode %u) red_alg %x (%p)",

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tm_node->red_algo == NIX_REDALG_SEND'
#348: FILE: drivers/net/octeontx2/otx2_tm.c:2959:
+		if ((red_send && (tm_node->red_algo == NIX_REDALG_SEND)) ||
+		    (!red_send && (tm_node->red_algo != NIX_REDALG_SEND)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tm_node->red_algo != NIX_REDALG_SEND'
#348: FILE: drivers/net/octeontx2/otx2_tm.c:2959:
+		if ((red_send && (tm_node->red_algo == NIX_REDALG_SEND)) ||
+		    (!red_send && (tm_node->red_algo != NIX_REDALG_SEND)))

CHECK:CAMELCASE: Avoid CamelCase: <otx2_dev_is_95xx_Ax>
#626: FILE: drivers/net/octeontx2/otx2_tm.c:3249:
+	if (otx2_dev_is_95xx_Ax(dev) ||

CHECK:CAMELCASE: Avoid CamelCase: <otx2_dev_is_96xx_Ax>
#627: FILE: drivers/net/octeontx2/otx2_tm.c:3250:
+	    otx2_dev_is_96xx_Ax(dev))

total: 0 errors, 0 warnings, 5 checks, 658 lines checked


More information about the test-report mailing list