[dpdk-test-report] |WARNING| pw68735 [PATCH 3/3] net/octeontx2: add Tx packet marking offload support

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Apr 17 09:24:25 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/68735

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'flags' - possible side-effects?
#334: FILE: drivers/net/octeontx2/otx2_tx.c:992:
+#define T(name, f7, f6, f5, f4, f3, f2, f1, f0, sz, flags)		\
 static uint16_t __rte_noinline	__hot					\
 otx2_nix_xmit_pkts_vec_ ## name(void *tx_queue,				\
 			struct rte_mbuf **tx_pkts, uint16_t pkts)	\
 {									\
 	uint64_t cmd[sz];						\
 									\
+	/* VLAN, TSTMP, TSO, MARK is not supported by vec */		\
 	if ((flags) & NIX_TX_OFFLOAD_VLAN_QINQ_F ||			\
 	    (flags) & NIX_TX_OFFLOAD_TSTAMP_F ||			\
+	    (flags) & NIX_TX_OFFLOAD_TSO_F ||				\
+	    (flags) & NIX_TX_OFFLOAD_MARK_F)				\
 		return 0;						\
 	return nix_xmit_pkts_vector(tx_queue, tx_pkts, pkts, cmd, (flags)); \
 }

total: 0 errors, 0 warnings, 1 checks, 1001 lines checked


More information about the test-report mailing list