[dpdk-test-report] |WARNING| pw79663 [PATCH v2 44/56] net/txgbe: add flow control support

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Oct 6 11:44:12 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79663

_coding style issues_


WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return
#277: FILE: drivers/net/txgbe/base/txgbe_hw.c:200:
+		goto out;
+		break;

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'fc_conf->high_water > max_high_water'
#769: FILE: drivers/net/txgbe/txgbe_ethdev.c:2772:
+	if ((fc_conf->high_water > max_high_water) ||
+	    (fc_conf->high_water < fc_conf->low_water)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'fc_conf->high_water < fc_conf->low_water'
#769: FILE: drivers/net/txgbe/txgbe_ethdev.c:2772:
+	if ((fc_conf->high_water > max_high_water) ||
+	    (fc_conf->high_water < fc_conf->low_water)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'err == 0'
#786: FILE: drivers/net/txgbe/txgbe_ethdev.c:2789:
+	if ((err == 0) || (err == TXGBE_ERR_FC_NOT_NEGOTIATED)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'err == TXGBE_ERR_FC_NOT_NEGOTIATED'
#786: FILE: drivers/net/txgbe/txgbe_ethdev.c:2789:
+	if ((err == 0) || (err == TXGBE_ERR_FC_NOT_NEGOTIATED)) {

total: 0 errors, 1 warnings, 4 checks, 708 lines checked


More information about the test-report mailing list