[dpdk-test-report] |WARNING| pw79664 [PATCH v2 46/56] net/txgbe: add priority flow control support
checkpatch at dpdk.org
checkpatch at dpdk.org
Tue Oct 6 11:44:16 CEST 2020
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79664
_coding style issues_
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'map[j] == i'
#286: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.c:214:
+ if ((map[j] == i) && (pfc_en & (1 << j))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pfc_conf->fc.high_water > max_high_water'
#369: FILE: drivers/net/txgbe/txgbe_ethdev.c:2831:
+ if ((pfc_conf->fc.high_water > max_high_water) ||
+ (pfc_conf->fc.high_water <= pfc_conf->fc.low_water)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pfc_conf->fc.high_water <= pfc_conf->fc.low_water'
#369: FILE: drivers/net/txgbe/txgbe_ethdev.c:2831:
+ if ((pfc_conf->fc.high_water > max_high_water) ||
+ (pfc_conf->fc.high_water <= pfc_conf->fc.low_water)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'err == 0'
#385: FILE: drivers/net/txgbe/txgbe_ethdev.c:2847:
+ if ((err == 0) || (err == TXGBE_ERR_FC_NOT_NEGOTIATED))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'err == TXGBE_ERR_FC_NOT_NEGOTIATED'
#385: FILE: drivers/net/txgbe/txgbe_ethdev.c:2847:
+ if ((err == 0) || (err == TXGBE_ERR_FC_NOT_NEGOTIATED))
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#425: FILE: drivers/net/txgbe/txgbe_rxtx.c:3321:
+ /*
+ * If the TC count is 8,and the default high_water is 48,
total: 0 errors, 1 warnings, 5 checks, 343 lines checked
More information about the test-report
mailing list