[dpdk-test-report] |WARNING| pw76207 [PATCH v1 03/42] net/txgbe: add device init and uninit

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Sep 9 01:26:44 CEST 2020
Previous message: [dpdk-test-report] |WARNING| pw76206 [PATCH v1 04/42] net/txgbe: add error types and dummy function
Next message: [dpdk-test-report] |WARNING| pw76208 [PATCH v1 06/42] net/txgbe: add EEPROM functions
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/76207

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#58: 
Add basic init and uninit function, registers and some macro definitions prepare for hardware infrastructure.

WARNING:MEMORY_BARRIER: memory barrier without comment
#392: FILE: drivers/net/txgbe/base/txgbe_osdep.h:151:
+#define mb()	rte_mb()

WARNING:MEMORY_BARRIER: memory barrier without comment
#393: FILE: drivers/net/txgbe/base/txgbe_osdep.h:152:
+#define wmb()	rte_wmb()

WARNING:MEMORY_BARRIER: memory barrier without comment
#394: FILE: drivers/net/txgbe/base/txgbe_osdep.h:153:
+#define rmb()	rte_rmb()

CHECK:CAMELCASE: Avoid CamelCase: <Address>
#414: FILE: drivers/net/txgbe/base/txgbe_osdep.h:173:
+#define TXGBE_IS_MULTICAST(Address) \

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'Address' - possible side-effects?
#418: FILE: drivers/net/txgbe/base/txgbe_osdep.h:177:
+#define TXGBE_IS_BROADCAST(Address) \
+		((((u8 *)(Address))[0] == ((u8)0xff)) && \
+		(((u8 *)(Address))[1] == ((u8)0xff)))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'y' - possible side-effects?
#466: FILE: drivers/net/txgbe/base/txgbe_regs.h:35:
+#define ROUND_UP(x, y)          (((x) + (y) - 1) / (y) * (y))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'y' - possible side-effects?
#467: FILE: drivers/net/txgbe/base/txgbe_regs.h:36:
+#define ROUND_DOWN(x, y)        ((x) / (y) * (y))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects?
#468: FILE: drivers/net/txgbe/base/txgbe_regs.h:37:
+#define ROUND_OVER(x, maxbits, unitbits) \
+	((x) >= 1 << (maxbits) ? 0 : (x) >> (unitbits))

CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_AUTOC_LMS_10Gs>
#486: FILE: drivers/net/txgbe/base/txgbe_regs.h:55:
+#define   TXGBE_AUTOC_LMS_10Gs            LS64(3, 13, 0x7)

CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_AUTOC_10Gs_PMA_PMD_MASK>
#513: FILE: drivers/net/txgbe/base/txgbe_regs.h:82:
+#define   TXGBE_AUTOC_10Gs_PMA_PMD_MASK   MS64(48, 0x3)  /* serial */

CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_AUTOC_10Gs_KR>
#514: FILE: drivers/net/txgbe/base/txgbe_regs.h:83:
+#define   TXGBE_AUTOC_10Gs_KR             LS64(0, 48, 0x3)

CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_AUTOC_10Gs_XFI>
#515: FILE: drivers/net/txgbe/base/txgbe_regs.h:84:
+#define   TXGBE_AUTOC_10Gs_XFI            LS64(1, 48, 0x3)

CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_AUTOC_10Gs_SFI>
#516: FILE: drivers/net/txgbe/base/txgbe_regs.h:85:
+#define   TXGBE_AUTOC_10Gs_SFI            LS64(2, 48, 0x3)

CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#587: FILE: drivers/net/txgbe/base/txgbe_regs.h:156:
+#define   TXGBE_RST_LAN(i)         MS(((i)+1), 0x1)
                                           ^

CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#589: FILE: drivers/net/txgbe/base/txgbe_regs.h:158:
+#define   TXGBE_RST_ETH(i)         MS(((i)+29), 0x1)
                                           ^

CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#640: FILE: drivers/net/txgbe/base/txgbe_regs.h:209:
+#define   TXGBE_FLASH_LANRSTD(i)   MS(((i)+9), 0x1)
                                           ^

CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#737: FILE: drivers/net/txgbe/base/txgbe_regs.h:306:
+#define   TXGBE_LEDCTL_OD(s)            MS(((s)+16), 0x1)
                                                ^

WARNING:TYPO_SPELLING: 'QUE' may be misspelled - perhaps 'QUEUE'?
#1258: FILE: drivers/net/txgbe/base/txgbe_regs.h:827:
+#define   TXGBE_FCRSSTBL_QUE(v)    LS(v, 0, 0x7F)

CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_MACRX1024toMAXL>
#1515: FILE: drivers/net/txgbe/base/txgbe_regs.h:1084:
+#define TXGBE_MACRX1024toMAXL        0x001968

CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_MACRX1024toMAXH>
#1516: FILE: drivers/net/txgbe/base/txgbe_regs.h:1085:
+#define TXGBE_MACRX1024toMAXH        0x00196C

CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_MACTX1024toMAXL>
#1527: FILE: drivers/net/txgbe/base/txgbe_regs.h:1096:
+#define TXGBE_MACTX1024toMAXL        0x00185C

CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_MACTX1024toMAXH>
#1528: FILE: drivers/net/txgbe/base/txgbe_regs.h:1097:
+#define TXGBE_MACTX1024toMAXH        0x001860

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tc' - possible side-effects?
#1688: FILE: drivers/net/txgbe/base/txgbe_regs.h:1257:
+#define   TXGBE_VFPBWRAP_WRAP(r, tc)    ((0x7 << 4 * (tc) & (r)) >> 4 * (tc))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tc' - possible side-effects?
#1689: FILE: drivers/net/txgbe/base/txgbe_regs.h:1258:
+#define   TXGBE_VFPBWRAP_EMPT(r, tc)    ((0x8 << 4 * (tc) & (r)) >> 4 * (tc))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tc' - possible side-effects?
#1889: FILE: drivers/net/txgbe/base/txgbe_regs.h:1458:
+#define   TXGBE_PBRXSTAT_WRAP(tc, r)    ((7u << 4 * (tc) & (r)) >> 4 * (tc))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tc' - possible side-effects?
#1890: FILE: drivers/net/txgbe/base/txgbe_regs.h:1459:
+#define   TXGBE_PBRXSTAT_EMPT(tc, r)    ((8u << 4 * (tc) & (r)) >> 4 * (tc))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tc' - possible side-effects?
#1903: FILE: drivers/net/txgbe/base/txgbe_regs.h:1472:
+#define   TXGBE_PBTXSTAT_EMPT(tc, r)    ((1 << (tc) & (r)) >> (tc))

WARNING:TYPO_SPELLING: 'sting' may be misspelled - perhaps 'string'?
#2127: FILE: drivers/net/txgbe/base/txgbe_regs.h:1696:
+#define NVM_VER_SIZE		32    /* version sting size */

WARNING:RETURN_VOID: void function return statements are not generally useful
#2188: FILE: drivers/net/txgbe/base/txgbe_regs.h:1757:
+	return;
+}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#2253: FILE: drivers/net/txgbe/base/txgbe_regs.h:1822:
+		if (value == expect) {
+			break;
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#2260: FILE: drivers/net/txgbe/base/txgbe_regs.h:1829:
+	if (actual) {
+		*actual = all;
+	}

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw' - possible side-effects?
#2275: FILE: drivers/net/txgbe/base/txgbe_regs.h:1844:
+#define rd32at(hw, reg, idx) \
+		rd32a(hw, txgbe_map_reg(hw, reg), idx)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw' - possible side-effects?
#2277: FILE: drivers/net/txgbe/base/txgbe_regs.h:1846:
+#define wr32at(hw, reg, idx, val) \
+		wr32a(hw, txgbe_map_reg(hw, reg), idx, val)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw' - possible side-effects?
#2280: FILE: drivers/net/txgbe/base/txgbe_regs.h:1849:
+#define rd32w(hw, reg, mask, slice) do { \
+	rd32((hw), reg); \
+	po32m((hw), reg, mask, mask, NULL, 5, slice); \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'reg' - possible side-effects?
#2280: FILE: drivers/net/txgbe/base/txgbe_regs.h:1849:
+#define rd32w(hw, reg, mask, slice) do { \
+	rd32((hw), reg); \
+	po32m((hw), reg, mask, mask, NULL, 5, slice); \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mask' - possible side-effects?
#2280: FILE: drivers/net/txgbe/base/txgbe_regs.h:1849:
+#define rd32w(hw, reg, mask, slice) do { \
+	rd32((hw), reg); \
+	po32m((hw), reg, mask, mask, NULL, 5, slice); \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw' - possible side-effects?
#2285: FILE: drivers/net/txgbe/base/txgbe_regs.h:1854:
+#define wr32w(hw, reg, val, mask, slice) do { \
+	wr32((hw), reg, val); \
+	po32m((hw), reg, mask, mask, NULL, 5, slice); \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'reg' - possible side-effects?
#2285: FILE: drivers/net/txgbe/base/txgbe_regs.h:1854:
+#define wr32w(hw, reg, val, mask, slice) do { \
+	wr32((hw), reg, val); \
+	po32m((hw), reg, mask, mask, NULL, 5, slice); \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mask' - possible side-effects?
#2285: FILE: drivers/net/txgbe/base/txgbe_regs.h:1854:
+#define wr32w(hw, reg, val, mask, slice) do { \
+	wr32((hw), reg, val); \
+	po32m((hw), reg, mask, mask, NULL, 5, slice); \
+} while (0)

CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#2543: FILE: drivers/net/txgbe/txgbe_ethdev.c:104:
+			txq = eth_dev->data->tx_queues[eth_dev->data->nb_tx_queues-1];
 			                                                          ^

WARNING:BRACES: braces {} are not necessary for single statement blocks
#2567: FILE: drivers/net/txgbe/txgbe_ethdev.c:128:
+	if (mz == NULL) {
+		return -ENOMEM;
+	}

CHECK:SPACING: No space is necessary after a cast
#2649: FILE: drivers/net/txgbe/txgbe_ethdev.c:209:
+			     (int)hw->mac.type, (int) hw->phy.type);

total: 0 errors, 10 warnings, 33 checks, 2750 lines checked
Warning in drivers/net/txgbe/base/txgbe_osdep.h:
Using rte_panic/rte_exit
Warning in drivers/net/txgbe/base/txgbe_osdep.h:
Using compiler attribute directly
Previous message: [dpdk-test-report] |WARNING| pw76206 [PATCH v1 04/42] net/txgbe: add error types and dummy function
Next message: [dpdk-test-report] |WARNING| pw76208 [PATCH v1 06/42] net/txgbe: add EEPROM functions
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list