[dpdk-test-report] |WARNING| pw76208 [PATCH v1 06/42] net/txgbe: add EEPROM functions

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/76208

_coding style issues_


WARNING:BRACES: braces {} are not necessary for single statement blocks
#124: FILE: drivers/net/txgbe/base/txgbe_eeprom.c:25:
+	if (eeprom->type != txgbe_eeprom_unknown) {
+		return 0;
+	}

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#130: FILE: drivers/net/txgbe/base/txgbe_eeprom.c:31:
+	 * tested value */

WARNING:BRACES: braces {} are not necessary for single statement blocks
#586: FILE: drivers/net/txgbe/base/txgbe_eeprom.c:487:
+		for (j = 0; j < seg; j++) {
+			checksum += buffer[j];
+		}

CHECK:SPACING: No space is necessary after a cast
#786: FILE: drivers/net/txgbe/base/txgbe_mng.c:24:
+	return (u8) (0 - sum);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#901: FILE: drivers/net/txgbe/base/txgbe_mng.c:139:
+	for (bi = 0; bi < dword_len; bi++) {
+		buffer[bi] = rd32a(hw, TXGBE_MNGMBX, bi);
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#911: FILE: drivers/net/txgbe/base/txgbe_mng.c:149:
+		for (; bi < dword_len + 2; bi++) {
+			buffer[bi] = rd32a(hw, TXGBE_MNGMBX, bi);
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#933: FILE: drivers/net/txgbe/base/txgbe_mng.c:171:
+	for (; bi <= dword_len; bi++) {
+		buffer[bi] = rd32a(hw, TXGBE_MNGMBX, bi);
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#981: FILE: drivers/net/txgbe/base/txgbe_mng.c:219:
+	for (i <<= 2; i < len; i++) {
+		((u8 *)buf)[i] = ((u8 *)&value)[j++];
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1019: FILE: drivers/net/txgbe/base/txgbe_mng.c:257:
+	for (i <<= 2; i < len; i++) {
+		((u8 *)&value)[j++] = ((u8 *)buf)[i];
+	}

WARNING:LONG_LINE: line over 100 characters
#1338: FILE: drivers/net/txgbe/base/txgbe_mng.h:171:
+s32 txgbe_hic_set_drv_ver(struct txgbe_hw *hw, u8 maj, u8 min, u8 build, u8 ver, u16 len, const char *str);

total: 0 errors, 9 warnings, 1 checks, 1256 lines checked