[dpdk-test-report] |WARNING| pw76217 [PATCH v1 14/42] net/txgbe: add link status change

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/76217

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#58: 
Add ethdev link interrupt handler, MAC setup link and check link status and get capabilities.

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#115: FILE: drivers/net/txgbe/base/txgbe_hw.c:246:
+{
+

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#188: FILE: drivers/net/txgbe/base/txgbe_hw.c:319:
+				break;
+			} else {

CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_AUTOC_10Gs_PMA_PMD_MASK>
#458: FILE: drivers/net/txgbe/base/txgbe_hw.c:856:
+	u64 pma_pmd_10gs = autoc & TXGBE_AUTOC_10Gs_PMA_PMD_MASK;

WARNING:BRACES: braces {} are not necessary for single statement blocks
#476: FILE: drivers/net/txgbe/base/txgbe_hw.c:874:
+	if (speed == TXGBE_LINK_SPEED_UNKNOWN) {
+		return TXGBE_ERR_LINK_SETUP;
+	}

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->phy.smart_speed_active == false'
#499: FILE: drivers/net/txgbe/base/txgbe_hw.c:897:
+			if ((orig_autoc & TXGBE_AUTOC_KR_SUPP) &&
+			    (hw->phy.smart_speed_active == false))

CHECK:BOOL_COMPARISON: Using comparison to false is error prone
#500: FILE: drivers/net/txgbe/base/txgbe_hw.c:898:
+			    (hw->phy.smart_speed_active == false))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'speed == TXGBE_LINK_SPEED_10GB_FULL'
#509: FILE: drivers/net/txgbe/base/txgbe_hw.c:907:
+		if ((speed == TXGBE_LINK_SPEED_10GB_FULL) &&
+		    (pma_pmd_10gs == TXGBE_AUTOC_10Gs_SFI)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pma_pmd_10gs == TXGBE_AUTOC_10Gs_SFI'
#509: FILE: drivers/net/txgbe/base/txgbe_hw.c:907:
+		if ((speed == TXGBE_LINK_SPEED_10GB_FULL) &&
+		    (pma_pmd_10gs == TXGBE_AUTOC_10Gs_SFI)) {

CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_AUTOC_10Gs_SFI>
#510: FILE: drivers/net/txgbe/base/txgbe_hw.c:908:
+		    (pma_pmd_10gs == TXGBE_AUTOC_10Gs_SFI)) {

CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_AUTOC_LMS_10Gs>
#512: FILE: drivers/net/txgbe/base/txgbe_hw.c:910:
+			autoc |= TXGBE_AUTOC_LMS_10Gs;

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'speed == TXGBE_LINK_SPEED_1GB_FULL'
#517: FILE: drivers/net/txgbe/base/txgbe_hw.c:915:
+		if ((speed == TXGBE_LINK_SPEED_1GB_FULL) &&
+		    (pma_pmd_1g == TXGBE_AUTOC_1G_SFI)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pma_pmd_1g == TXGBE_AUTOC_1G_SFI'
#517: FILE: drivers/net/txgbe/base/txgbe_hw.c:915:
+		if ((speed == TXGBE_LINK_SPEED_1GB_FULL) &&
+		    (pma_pmd_1g == TXGBE_AUTOC_1G_SFI)) {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#527: FILE: drivers/net/txgbe/base/txgbe_hw.c:925:
+	if (autoc == current_autoc) {
+		return status;
+	}

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'status != 0'
#614: FILE: drivers/net/txgbe/base/txgbe_hw.c:1196:
+	if ((status != 0) ||
+	    (fw_offset == 0) || (fw_offset == 0xFFFF))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'fw_offset == 0'
#614: FILE: drivers/net/txgbe/base/txgbe_hw.c:1196:
+	if ((status != 0) ||
+	    (fw_offset == 0) || (fw_offset == 0xFFFF))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'fw_offset == 0xFFFF'
#614: FILE: drivers/net/txgbe/base/txgbe_hw.c:1196:
+	if ((status != 0) ||
+	    (fw_offset == 0) || (fw_offset == 0xFFFF))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'status != 0'
#623: FILE: drivers/net/txgbe/base/txgbe_hw.c:1205:
+	if ((status != 0) ||
+	    (fw_lesm_param_offset == 0) || (fw_lesm_param_offset == 0xFFFF))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'fw_lesm_param_offset == 0'
#623: FILE: drivers/net/txgbe/base/txgbe_hw.c:1205:
+	if ((status != 0) ||
+	    (fw_lesm_param_offset == 0) || (fw_lesm_param_offset == 0xFFFF))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'fw_lesm_param_offset == 0xFFFF'
#623: FILE: drivers/net/txgbe/base/txgbe_hw.c:1205:
+	if ((status != 0) ||
+	    (fw_lesm_param_offset == 0) || (fw_lesm_param_offset == 0xFFFF))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'status == 0'
#632: FILE: drivers/net/txgbe/base/txgbe_hw.c:1214:
+	if ((status == 0) &&
+	    (fw_lesm_state & TXGBE_FW_LESM_STATE_ENABLED))

WARNING:BRACES: braces {} are not necessary for single statement blocks
#657: FILE: drivers/net/txgbe/base/txgbe_hw.c:1239:
+	if (autoc & TXGBE_AUTOC_LINK_DIA_MASK) {
+		autoc &= ~TXGBE_AUTOC_LINK_DIA_MASK;
+	}

CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#688: FILE: drivers/net/txgbe/base/txgbe_hw.h:28:
+extern s32 txgbe_reset_pipeline_raptor(struct txgbe_hw *hw);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1292: FILE: drivers/net/txgbe/txgbe_ethdev.c:1039:
+					(unsigned)link.link_speed,

total: 0 errors, 6 warnings, 18 checks, 1203 lines checked