[dpdk-test-report] |WARNING| pw76218 [PATCH v1 16/42] net/txgbe: add autoc read and write
checkpatch at dpdk.org
checkpatch at dpdk.org
Wed Sep 9 01:27:33 CEST 2020
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/76218
_coding style issues_
WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
#115: FILE: drivers/net/txgbe/base/txgbe_phy.c:1402:
+ msleep(10);
WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
#128: FILE: drivers/net/txgbe/base/txgbe_phy.c:1415:
+ msleep(1);
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#130: FILE: drivers/net/txgbe/base/txgbe_phy.c:1417:
+ * for corresponding LAN port */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#157: FILE: drivers/net/txgbe/base/txgbe_phy.c:1444:
+ * Control1 Register Bit[15](VR_RST) */
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 17)
#172: FILE: drivers/net/txgbe/base/txgbe_phy.c:1459:
+ } else {
+ wr32_epcs(hw, VR_AN_KR_MODE_CL, 0x1);
WARNING:BRACES: braces {} are not necessary for single statement blocks
#187: FILE: drivers/net/txgbe/base/txgbe_phy.c:1474:
+ if (hw->link_status == TXGBE_LINK_STATUS_KX4) {
+ goto out;
+ }
WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
#197: FILE: drivers/net/txgbe/base/txgbe_phy.c:1484:
+ msleep(10);
WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
#216: FILE: drivers/net/txgbe/base/txgbe_phy.c:1503:
+ msleep(1);
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#219: FILE: drivers/net/txgbe/base/txgbe_phy.c:1506:
+ * for corresponding LAN port */
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#261: FILE: drivers/net/txgbe/base/txgbe_phy.c:1548:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY MPLLA
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#267: FILE: drivers/net/txgbe/base/txgbe_phy.c:1554:
+ /* Set VR XS, PMA or MII Synopsys Enterprise Gen5 12G PHY MPLLA
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#273: FILE: drivers/net/txgbe/base/txgbe_phy.c:1560:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY VCO
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#279: FILE: drivers/net/txgbe/base/txgbe_phy.c:1566:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY VCO
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#285: FILE: drivers/net/txgbe/base/txgbe_phy.c:1572:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY VCO
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#290: FILE: drivers/net/txgbe/base/txgbe_phy.c:1577:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY VCO
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#295: FILE: drivers/net/txgbe/base/txgbe_phy.c:1582:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY VCO
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#300: FILE: drivers/net/txgbe/base/txgbe_phy.c:1587:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY VCO
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#305: FILE: drivers/net/txgbe/base/txgbe_phy.c:1592:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY AFE-DFE
WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#305: FILE: drivers/net/txgbe/base/txgbe_phy.c:1592:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY AFE-DFE
WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#306: FILE: drivers/net/txgbe/base/txgbe_phy.c:1593:
+ * Enable Register Bit[7:0] = 8'd0 //AFE_EN_0/3_1, DFE_EN_0/3_1
WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#308: FILE: drivers/net/txgbe/base/txgbe_phy.c:1595:
+ wr32_epcs(hw, TXGBE_PHY_AFE_DFE_ENABLE, 0x0);
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#310: FILE: drivers/net/txgbe/base/txgbe_phy.c:1597:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY Rx
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#315: FILE: drivers/net/txgbe/base/txgbe_phy.c:1602:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY Tx Rate
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#321: FILE: drivers/net/txgbe/base/txgbe_phy.c:1608:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY Rx Rate
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#327: FILE: drivers/net/txgbe/base/txgbe_phy.c:1614:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY Tx General
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#332: FILE: drivers/net/txgbe/base/txgbe_phy.c:1619:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY Rx General
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#337: FILE: drivers/net/txgbe/base/txgbe_phy.c:1624:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY MPLLA Control
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#349: FILE: drivers/net/txgbe/base/txgbe_phy.c:1636:
+ * Register Bit[15](VR_RST) */
WARNING:BRACES: braces {} are not necessary for single statement blocks
#383: FILE: drivers/net/txgbe/base/txgbe_phy.c:1670:
+ if (hw->link_status == TXGBE_LINK_STATUS_KX) {
+ goto out;
+ }
WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
#393: FILE: drivers/net/txgbe/base/txgbe_phy.c:1680:
+ msleep(10);
WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
#412: FILE: drivers/net/txgbe/base/txgbe_phy.c:1699:
+ msleep(1);
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#415: FILE: drivers/net/txgbe/base/txgbe_phy.c:1702:
+ * for corresponding LAN port */
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#471: FILE: drivers/net/txgbe/base/txgbe_phy.c:1758:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY MPLLA Control
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#477: FILE: drivers/net/txgbe/base/txgbe_phy.c:1764:
+ /* Set VR XS, PMA or MII Synopsys Enterprise Gen5 12G PHY MPLLA Control
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#483: FILE: drivers/net/txgbe/base/txgbe_phy.c:1770:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY VCO
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#493: FILE: drivers/net/txgbe/base/txgbe_phy.c:1780:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY VCO
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#501: FILE: drivers/net/txgbe/base/txgbe_phy.c:1788:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY AFE-DFE
WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#501: FILE: drivers/net/txgbe/base/txgbe_phy.c:1788:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY AFE-DFE
WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#502: FILE: drivers/net/txgbe/base/txgbe_phy.c:1789:
+ * Enable Register Bit[4], Bit[0] = 1'b0 //AFE_EN_0, DFE_EN_0
WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#504: FILE: drivers/net/txgbe/base/txgbe_phy.c:1791:
+ wr32_epcs(hw, TXGBE_PHY_AFE_DFE_ENABLE,
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#506: FILE: drivers/net/txgbe/base/txgbe_phy.c:1793:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY Rx
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#511: FILE: drivers/net/txgbe/base/txgbe_phy.c:1798:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY Tx Rate
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#517: FILE: drivers/net/txgbe/base/txgbe_phy.c:1804:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY Rx Rate
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#523: FILE: drivers/net/txgbe/base/txgbe_phy.c:1810:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY Tx General
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#528: FILE: drivers/net/txgbe/base/txgbe_phy.c:1815:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY Rx General
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#533: FILE: drivers/net/txgbe/base/txgbe_phy.c:1820:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY MPLLA Control
WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
#587: FILE: drivers/net/txgbe/base/txgbe_phy.c:1874:
+ msleep(10);
WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
#603: FILE: drivers/net/txgbe/base/txgbe_phy.c:1890:
+ msleep(1);
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#605: FILE: drivers/net/txgbe/base/txgbe_phy.c:1892:
+ * for corresponding LAN port */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#700: FILE: drivers/net/txgbe/base/txgbe_phy.c:1987:
+ * Bit[7:0](DFE_TAP1_0) = 8'd20 */
WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#702: FILE: drivers/net/txgbe/base/txgbe_phy.c:1989:
+ value = rd32_epcs(hw, TXGBE_PHY_AFE_DFE_ENABLE);
WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#704: FILE: drivers/net/txgbe/base/txgbe_phy.c:1991:
+ wr32_epcs(hw, TXGBE_PHY_AFE_DFE_ENABLE, value);
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#707: FILE: drivers/net/txgbe/base/txgbe_phy.c:1994:
+ * Bit[7:0](DFE_TAP1_0) = 8'd20 */
WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#709: FILE: drivers/net/txgbe/base/txgbe_phy.c:1996:
+ /* 9. Set VR_MII_Gen5_12G_AFE_DFE_EN_CTRL Register
WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#710: FILE: drivers/net/txgbe/base/txgbe_phy.c:1997:
+ * Bit[4](DFE_EN_0) = 1'b0, Bit[0](AFE_EN_0) = 1'b0 */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#710: FILE: drivers/net/txgbe/base/txgbe_phy.c:1997:
+ * Bit[4](DFE_EN_0) = 1'b0, Bit[0](AFE_EN_0) = 1'b0 */
WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#711: FILE: drivers/net/txgbe/base/txgbe_phy.c:1998:
+ value = rd32_epcs(hw, TXGBE_PHY_AFE_DFE_ENABLE);
WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#713: FILE: drivers/net/txgbe/base/txgbe_phy.c:2000:
+ wr32_epcs(hw, TXGBE_PHY_AFE_DFE_ENABLE, value);
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#734: FILE: drivers/net/txgbe/base/txgbe_phy.c:2021:
+ * Bit[12:8](RX_VREF_CTRL) = 5'hF */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#737: FILE: drivers/net/txgbe/base/txgbe_phy.c:2024:
+ * Bit[13:8](TX_EQ_MAIN) = 6'd30, Bit[5:0](TX_EQ_PRE) = 6'd4 */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#742: FILE: drivers/net/txgbe/base/txgbe_phy.c:2029:
+ * (TX_EQ_OVR_RIDE) = 1'b1, Bit[5:0](TX_EQ_POST) = 6'd36 */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#763: FILE: drivers/net/txgbe/base/txgbe_phy.c:2050:
+ * Bit[7:0](DFE_TAP1_0) = 8'd00 */
WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#765: FILE: drivers/net/txgbe/base/txgbe_phy.c:2052:
+ /* 9. Set VR_MII_Gen5_12G_AFE_DFE_EN_CTRL Register
WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#766: FILE: drivers/net/txgbe/base/txgbe_phy.c:2053:
+ * Bit[4](DFE_EN_0) = 1'b0, Bit[0](AFE_EN_0) = 1'b0 */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#766: FILE: drivers/net/txgbe/base/txgbe_phy.c:2053:
+ * Bit[4](DFE_EN_0) = 1'b0, Bit[0](AFE_EN_0) = 1'b0 */
WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#774: FILE: drivers/net/txgbe/base/txgbe_phy.c:2061:
+ wr32_epcs(hw, TXGBE_PHY_AFE_DFE_ENABLE, 0x0);
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#784: FILE: drivers/net/txgbe/base/txgbe_phy.c:2071:
+ * Register Bit[15](VR_RST) */
CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_AUTOC_LMS_10Gs>
#816: FILE: drivers/net/txgbe/base/txgbe_phy.c:2103:
+ autoc |= TXGBE_AUTOC_LMS_10Gs;
CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_AUTOC_10Gs_SFI>
#820: FILE: drivers/net/txgbe/base/txgbe_phy.c:2107:
+ TXGBE_AUTOC_10Gs_SFI;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#833: FILE: drivers/net/txgbe/base/txgbe_phy.c:2120:
+ if (hw->device_id != TXGBE_DEV_ID_RAPTOR_SGMII) {
+ return autoc;
+ }
CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_AUTOC_10Gs_KR>
#861: FILE: drivers/net/txgbe/base/txgbe_phy.c:2148:
+ TXGBE_AUTOC_10Gs_KR;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#865: FILE: drivers/net/txgbe/base/txgbe_phy.c:2152:
+ if (sr_an_adv_reg2 & SR_AN_MMD_ADV_REG2_BP_TYPE_KR) {
+ autoc |= TXGBE_AUTOC_10G_KR;
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#868: FILE: drivers/net/txgbe/base/txgbe_phy.c:2155:
+ if (sr_an_adv_reg2 & SR_AN_MMD_ADV_REG2_BP_TYPE_KX4) {
+ autoc |= TXGBE_AUTOC_10G_KX4;
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#871: FILE: drivers/net/txgbe/base/txgbe_phy.c:2158:
+ if (sr_an_adv_reg2 & SR_AN_MMD_ADV_REG2_BP_TYPE_KX) {
+ autoc |= TXGBE_AUTOC_1G_KX;
+ }
WARNING:BRACES: braces {} are not necessary for any arm of this statement
#928: FILE: drivers/net/txgbe/base/txgbe_phy.c:2215:
+ if (speed == TXGBE_LINK_SPEED_10GB_FULL) {
[...]
+ } else if (speed == TXGBE_LINK_SPEED_1GB_FULL) {
[...]
total: 0 errors, 72 warnings, 3 checks, 899 lines checked
More information about the test-report
mailing list