|WARNING| pw137806 [RFC 6/7] eal: add generic atomic bit operations

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/137806

_coding style issues_


ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#148: FILE: lib/eal/include/rte_bitops.h:311:
+		 uint32_t *: rte_bit_atomic_test32,			\
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#148: FILE: lib/eal/include/rte_bitops.h:311:
+		 uint32_t *: rte_bit_atomic_test32,			\
 		           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#149: FILE: lib/eal/include/rte_bitops.h:312:
+		 uint64_t *: rte_bit_atomic_test64)(addr, nr, memory_order)
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#149: FILE: lib/eal/include/rte_bitops.h:312:
+		 uint64_t *: rte_bit_atomic_test64)(addr, nr, memory_order)
 		           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#167: FILE: lib/eal/include/rte_bitops.h:330:
+		 uint32_t *: rte_bit_atomic_set32,			\
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#167: FILE: lib/eal/include/rte_bitops.h:330:
+		 uint32_t *: rte_bit_atomic_set32,			\
 		           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#168: FILE: lib/eal/include/rte_bitops.h:331:
+		 uint64_t *: rte_bit_atomic_set64)(addr, nr, memory_order)
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#168: FILE: lib/eal/include/rte_bitops.h:331:
+		 uint64_t *: rte_bit_atomic_set64)(addr, nr, memory_order)
 		           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#186: FILE: lib/eal/include/rte_bitops.h:349:
+		 uint32_t *: rte_bit_atomic_clear32,			\
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#186: FILE: lib/eal/include/rte_bitops.h:349:
+		 uint32_t *: rte_bit_atomic_clear32,			\
 		           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#187: FILE: lib/eal/include/rte_bitops.h:350:
+		 uint64_t *: rte_bit_atomic_clear64)(addr, nr, memory_order)
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#187: FILE: lib/eal/include/rte_bitops.h:350:
+		 uint64_t *: rte_bit_atomic_clear64)(addr, nr, memory_order)
 		           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#207: FILE: lib/eal/include/rte_bitops.h:370:
+		 uint32_t *: rte_bit_atomic_assign32,			\
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#207: FILE: lib/eal/include/rte_bitops.h:370:
+		 uint32_t *: rte_bit_atomic_assign32,			\
 		           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#208: FILE: lib/eal/include/rte_bitops.h:371:
+		 uint64_t *: rte_bit_atomic_assign64)(addr, nr, value,	\
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#208: FILE: lib/eal/include/rte_bitops.h:371:
+		 uint64_t *: rte_bit_atomic_assign64)(addr, nr, value,	\
 		           ^

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#227: FILE: lib/eal/include/rte_bitops.h:390:
+#define rte_bit_atomic_test_and_set(addr, nr, memory_order)		\
+	_Generic((addr),						\
+		 uint32_t *: rte_bit_atomic_test_and_set32,		\
+		 uint64_t *: rte_bit_atomic_test_and_set64)(addr, nr,	\
+							    memory_order))

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#229: FILE: lib/eal/include/rte_bitops.h:392:
+		 uint32_t *: rte_bit_atomic_test_and_set32,		\
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#229: FILE: lib/eal/include/rte_bitops.h:392:
+		 uint32_t *: rte_bit_atomic_test_and_set32,		\
 		           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#230: FILE: lib/eal/include/rte_bitops.h:393:
+		 uint64_t *: rte_bit_atomic_test_and_set64)(addr, nr,	\
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#230: FILE: lib/eal/include/rte_bitops.h:393:
+		 uint64_t *: rte_bit_atomic_test_and_set64)(addr, nr,	\
 		           ^

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#249: FILE: lib/eal/include/rte_bitops.h:412:
+#define rte_bit_atomic_test_and_clear(addr, nr, memory_order)		\
+	_Generic((addr),						\
+		 uint32_t *: rte_bit_atomic_test_and_clear32,		\
+		 uint64_t *: rte_bit_atomic_test_and_clear64)(addr, nr, \
+							      memory_order))

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#251: FILE: lib/eal/include/rte_bitops.h:414:
+		 uint32_t *: rte_bit_atomic_test_and_clear32,		\
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#251: FILE: lib/eal/include/rte_bitops.h:414:
+		 uint32_t *: rte_bit_atomic_test_and_clear32,		\
 		           ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxO)
#252: FILE: lib/eal/include/rte_bitops.h:415:
+		 uint64_t *: rte_bit_atomic_test_and_clear64)(addr, nr, \
 		          ^

ERROR:SPACING: spaces required around that ':' (ctx:OxW)
#252: FILE: lib/eal/include/rte_bitops.h:415:
+		 uint64_t *: rte_bit_atomic_test_and_clear64)(addr, nr, \
 		           ^

total: 26 errors, 0 warnings, 131 lines checked