|WARNING| pw137805 [RFC 5/7] eal: add atomic bit operations

checkpatch at dpdk.org checkpatch at dpdk.org
Sat Mar 2 15:03:14 CET 2024


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/137805

_coding style issues_


ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#397: FILE: lib/eal/include/rte_bitops.h:967:
+	rte_bit_atomic_test ## size(const uint ## size ## _t *addr,	\
 	                                                     ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#408: FILE: lib/eal/include/rte_bitops.h:978:
+	rte_bit_atomic_set ## size(uint ## size ## _t *addr,		\
 	                                              ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#419: FILE: lib/eal/include/rte_bitops.h:989:
+	rte_bit_atomic_clear ## size(uint ## size ## _t *addr,		\
 	                                                ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#430: FILE: lib/eal/include/rte_bitops.h:1000:
+	rte_bit_atomic_assign ## size(uint ## size ## _t *addr,		\
 	                                                 ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#442: FILE: lib/eal/include/rte_bitops.h:1012:
+	__rte_bit_atomic_test_and_assign ## size(uint ## size ## _t *addr, \
 	                                                            ^

ERROR:SPACING: space required before the open parenthesis '('
#456: FILE: lib/eal/include/rte_bitops.h:1026:
+		} while(!__atomic_compare_exchange_n(addr, &before, after, \

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#466: FILE: lib/eal/include/rte_bitops.h:1036:
+#define __RTE_GEN_BIT_ATOMIC_OPS(size)			\
+	__RTE_GEN_BIT_ATOMIC_TEST(size)			\
+	__RTE_GEN_BIT_ATOMIC_SET(size)			\
+	__RTE_GEN_BIT_ATOMIC_CLEAR(size)		\
+	__RTE_GEN_BIT_ATOMIC_ASSIGN(size)		\
+	__RTE_GEN_BIT_ATOMIC_TEST_AND_ASSIGN(size)

total: 7 errors, 0 warnings, 349 lines checked
Warning in lib/eal/include/rte_bitops.h:
Using __atomic_xxx/__ATOMIC_XXX built-ins, prefer rte_atomic_xxx/rte_memory_order_xxx


More information about the test-report mailing list