|SUCCESS| [v7] mempool/dpaa: update for new mempool cache algorithm

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/164749

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-06-01

I will review this DPDK patch for correctness bugs, coding style compliance, API requirements, and guideline violations.

git sha: 20260601183621.252920-2-mb at smartsharesystems.com
Author: Morten Brorup <mb at smartsharesystems.com>
Subject: mempool/dpaa: update for new mempool cache algorithm

This patch updates the DPAA mempool driver to remove modification of the
obsolete flushthresh field in mempool cache structures, as a consequence
of improvements to the mempool cache algorithm.

> diff --git a/drivers/mempool/dpaa/dpaa_mempool.c b/drivers/mempool/dpaa/dpaa_mempool.c
> index 2f9395b3f4..2f8555a026 100644
> --- a/drivers/mempool/dpaa/dpaa_mempool.c
> +++ b/drivers/mempool/dpaa/dpaa_mempool.c
> @@ -58,8 +58,6 @@ dpaa_mbuf_create_pool(struct rte_mempool *mp)
>  	struct bman_pool_params params = {
>  		.flags = BMAN_POOL_FLAG_DYNAMIC_BPID
>  	};
> -	unsigned int lcore_id;
> -	struct rte_mempool_cache *cache;
>  
>  	MEMPOOL_INIT_FUNC_TRACE();
>  

[ ... ]

> @@ -129,18 +127,6 @@ dpaa_mbuf_create_pool(struct rte_mempool *mp)
>  	rte_memcpy(bp_info, (void *)&rte_dpaa_bpid_info[bpid],
>  		   sizeof(struct dpaa_bp_info));
>  	mp->pool_data = (void *)bp_info;
> -	/* Update per core mempool cache threshold to optimal value which is
> -	 * number of buffers that can be released to HW buffer pool in
> -	 * a single API call.
> -	 */
> -	for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
> -		cache = &mp->local_cache[lcore_id];
> -		DPAA_MEMPOOL_DEBUG("lCore %d: cache->flushthresh %d -> %d",
> -			lcore_id, cache->flushthresh,
> -			(uint32_t)(cache->size + DPAA_MBUF_MAX_ACQ_REL));
> -		if (cache->flushthresh)
> -			cache->flushthresh = cache->size + DPAA_MBUF_MAX_ACQ_REL;
> -	}
>  
>  	DPAA_MEMPOOL_INFO("BMAN pool created for bpid =%d", bpid);
>  	return 0;

The patch looks correct and properly removes code that is no longer
needed. The removal of the flushthresh manipulation is appropriate given
the dependency on the mempool cache algorithm improvements. The unused
variable declarations are properly cleaned up.

However, I have one concern about the dependency chain:

Does the dependent patch "mempool: improve cache behaviour and
performance" (patch-164745) guarantee that the DPAA hardware constraints
represented by DPAA_MBUF_MAX_ACQ_REL are still properly handled? The
removed code was tuning the cache flush threshold to align with hardware
buffer release limits. Does the new algorithm in the core mempool code
account for driver-specific hardware constraints, or does this need to be
handled differently in the DPAA driver?