|SUCCESS| [v7] mempool/dpaa2: update for new mempool cache algorithm

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/164748

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-06-02

commit <SHA will be determined upon integration>
Author: Morten Brorup <mb at smartsharesystems.com>

mempool/dpaa2: update for new mempool cache algorithm

As a consequence of the improved mempool cache algorithm, the mempool
driver was updated to not modify the mempool cache's flushthresh field,
which is now obsolete, and modifying it has no effect.

> diff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
> index 02b6741853..ee001d8ce0 100644
> --- a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
> +++ b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
> @@ -54,8 +54,6 @@ rte_hw_mbuf_create_pool(struct rte_mempool *mp)
>  	struct dpaa2_bp_info *bp_info;
>  	struct dpbp_attr dpbp_attr;
>  	uint32_t bpid;
> -	unsigned int lcore_id;
> -	struct rte_mempool_cache *cache;
>  	int ret;
>  
>  	avail_dpbp = dpaa2_alloc_dpbp_dev();

[ ... ]

> @@ -152,18 +150,6 @@ rte_hw_mbuf_create_pool(struct rte_mempool *mp)
>  	DPAA2_MEMPOOL_DEBUG("BP List created for bpid =%d", dpbp_attr.bpid);
>  
>  	h_bp_list = bp_list;
> -	/* Update per core mempool cache threshold to optimal value which is
> -	 * number of buffers that can be released to HW buffer pool in
> -	 * a single API call.
> -	 */
> -	for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
> -		cache = &mp->local_cache[lcore_id];
> -		DPAA2_MEMPOOL_DEBUG("lCore %d: cache->flushthresh %d -> %d",
> -			lcore_id, cache->flushthresh,
> -			(uint32_t)(cache->size + DPAA2_MBUF_MAX_ACQ_REL));
> -		if (cache->flushthresh)
> -			cache->flushthresh = cache->size + DPAA2_MBUF_MAX_ACQ_REL;
> -	}
>  
>  	return 0;

This patch depends on patch-164745 which obsoletes the flushthresh field.
Does the obsolete field still exist in the structure for ABI
compatibility, or has it been completely removed? If removed, is this
causing an ABI breakage that needs to be documented?

Does any other part of the dpaa2 driver still reference cache->flushthresh
or assume the old flush behavior? Was the DPAA2_MBUF_MAX_ACQ_REL constant
used anywhere else in the driver to batch operations based on the old
threshold?

>  err4: