[dpdk-dev] Making rte_eal_pci_probe() in rte_eal_init() optional?

Roger B. Melton rmelton at cisco.com
Tue Nov 17 14:56:37 CET 2015


Hi David,  in-line -Roger

On 11/16/15 4:46 AM, David Marchand wrote:
> Hello Roger,
>
> On Sun, Nov 15, 2015 at 3:45 PM, Roger B. Melton <rmelton at cisco.com 
> <mailto:rmelton at cisco.com>> wrote:
>
>     I like the "-b all" and "-w none" idea, but I think it might be
>     complicated to implement it the way we would need it to work.  The
>     existing -b and -w options  persist for the duration of the
>     application, and we would need the "-b all"/"-w none" to persists
>     only through rte_eal_init() time.  Otherwise our attempt to to
>     attach a device at a later time would be blocked by the option.
>
>
> I agree, the black/white lists should only apply to initial scan.
> I forgot about this problem ...
> I had started some cleanup in the pci scan / attach code but this is 
> too late for 2.2, I will post this in the next merge window.
>
>
>     Wouldn't it be simpler to have an option to disable the
>     rte_eal_init() time the probe.  Would that address the issue with
>     VFIO, prevent automatically attaching to devices while permitting
>     on demand attach?
>
>
> I suppose we can do this yes (I think Thomas once proposed off-list an 
> option like --no-pci-scan).
> Do you think you can send a patch ?

What about --no-pci-init-probe?  I know it's long, but it is more 
descriptive of it's purpose to disable only the init time pci probe.

I code and test and have it ready.  I'm still working through internal 
processes to allow me to submit patches, but I hope to have that 
resolved in the next few weeks and at that time I can submit the patch.
>
>
> -- 
> David Marchand
>



More information about the dev mailing list