[dpdk-dev] [PATCH 00/19] A new net PMD - ice

Thomas Monjalon thomas at monjalon.net
Wed Dec 5 08:28:34 CET 2018


05/12/2018 07:39, Lu, Wenzhuo:
> From: Thomas Monjalon [mailto:thomas at monjalon.net]
> > 23/11/2018 07:56, Wenzhuo Lu:
> > >   net/ice: add base code
> > 
> > This first patch is really too big.
> > Please could you try to split it logically?
> 
> This is base code which is not developed by us. We're not so familiar with it. It's the first time to release the code, I know it's too big, to us too. But anyway we'll maintain it. 
> To save the effort, we always don't split the base code when releasing it at the first time. Is that OK?

It's not the best start.
How a very new driver can start with so many code and not being fully
understood by those who will maintain it?

It's really better to start small and grow.
It would ease both testing and understanding.




More information about the dev mailing list