[dpdk-dev] [PATCH 00/19] A new net PMD - ice
wenzhuo.lu at intel.com
Wed Dec 5 09:19:46 CET 2018
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas at monjalon.net]
> Sent: Wednesday, December 5, 2018 3:29 PM
> To: Lu, Wenzhuo <wenzhuo.lu at intel.com>
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 00/19] A new net PMD - ice
> 05/12/2018 07:39, Lu, Wenzhuo:
> > From: Thomas Monjalon [mailto:thomas at monjalon.net]
> > > 23/11/2018 07:56, Wenzhuo Lu:
> > > > net/ice: add base code
> > >
> > > This first patch is really too big.
> > > Please could you try to split it logically?
> > This is base code which is not developed by us. We're not so familiar with
> it. It's the first time to release the code, I know it's too big, to us too. But
> anyway we'll maintain it.
> > To save the effort, we always don't split the base code when releasing it at
> the first time. Is that OK?
> It's not the best start.
> How a very new driver can start with so many code and not being fully
> understood by those who will maintain it?
> It's really better to start small and grow.
> It would ease both testing and understanding.
Agree ideally it's much better if I can understand the whole code. But there's about 26K lines of code. I cannot lie to say I or any single person can fully understand all of them. There's a team that's supporting us. If any bug related to the code, we'll ask the help from the team. Even we found the root cause of the bug, we'd like getting confirm from them. That's how we make it work for all our NICs.
More information about the dev