[dpdk-dev] [PATCH] examples: remove Rx checksum offload

[Ananyev, Konstantin]

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas at monjalon.net]
> Sent: Monday, July 30, 2018 10:51 AM
> To: Jerin Jacob <jerin.jacob at caviumnetworks.com>; Ananyev, Konstantin <konstantin.ananyev at intel.com>
> Cc: dev at dpdk.org; Yigit, Ferruh <ferruh.yigit at intel.com>; shahafs at mellanox.com
> Subject: Re: [dpdk-dev] [PATCH] examples: remove Rx checksum offload
> 
> 30/07/2018 11:35, Jerin Jacob:
> > From: "Ananyev, Konstantin" <konstantin.ananyev at intel.com>
> > > >
> > > > As of now, application does not check PKT_RX_*_CKSUM_* flags per
> > > > packet, so it does not matter DEV_RX_OFFLOAD_CHECKSUM enabled or not.
> > > >
> > > > Removing DEV_RX_OFFLOAD_CHECKSUM offload so that driver can save a few
> > > > cycles if possible.
> > >
> > > Personally, I'd move in other direction: keep RX checksum offload and add
> > > checks inside sample apps to handle (drop) packets with invalid checksum.
> >
> > OK. Till someones add the DROP logic in application, Can we take
> > this patch? Because there is no point in enabling DEV_RX_OFFLOAD_CHECKSUM
> > without DROP or any meaning full action in application.

Probably, but at least it gives users a right estimation how long the proper
RX/TX routine would take.
>From other side what the point to disable these flags now, if we know that
we are doing wrong thing and will have to re-enable them again in future?

> 
> If there is no patch sent to use this offload on August 1st,
> then I will apply this patch to remove the offload request.
> 

Isn't it too late to do such things right now?
We are in RC3 stage and doesn't look like a critical issue.
Konstantin