[dpdk-dev] [PATCH v4 1/5] app/compress-perf: add parser
Varghese, Vipin
vipin.varghese at intel.com
Fri Nov 23 16:10:51 CET 2018
<snipped>
> +#define MAX_DRIVER_NAME 64
> +#define MAX_INPUT_FILE_NAME 64
<snipped>
> +comp_perf_options_check(struct comp_test_data *test_data) {
> + if (strcmp(test_data->driver_name, "") == 0) {
Should we use strncmp for boundary?
> + RTE_LOG(ERR, USER1, "Driver name has to be set\n");
> + return -1;
> + }
> +
> + if (strcmp(test_data->input_file, "") == 0) {
Should we use strncmp for boundary?
> + RTE_LOG(ERR, USER1, "Input file name has to be set\n");
> + return -1;
> + }
> +
<snipped>
> + test_data = rte_zmalloc_socket(NULL, sizeof(struct comp_test_data),
> + 0, rte_socket_id());
Suggestion: if the PMD is socket specific, do we need to alloc socket specific too? (assuming HW or SW socket specific PMD can be used)
<snipped>
More information about the dev
mailing list