[dpdk-dev] [PATCH v4 1/5] app/compress-perf: add parser
Bruce Richardson
bruce.richardson at intel.com
Fri Nov 23 16:24:38 CET 2018
On Fri, Nov 23, 2018 at 03:10:51PM +0000, Varghese, Vipin wrote:
> <snipped>
>
> > +#define MAX_DRIVER_NAME 64
> > +#define MAX_INPUT_FILE_NAME 64
>
> <snipped>
>
> > +comp_perf_options_check(struct comp_test_data *test_data) {
> > + if (strcmp(test_data->driver_name, "") == 0) {
>
> Should we use strncmp for boundary?
>
Shouldn't be necessary here, but a better check might be just to check if
test_data->driver_name[0] == '\0'. No need to use a string function for
checking for an empty string.
/Bruce
More information about the dev
mailing list