[dpdk-dev] [PATCH v5 1/3] net/tap: add queue and port ids in Rx/Tx queues structures

Thomas Monjalon thomas at monjalon.net
Wed Oct 10 16:07:47 CEST 2018


10/10/2018 14:50, Wiles, Keith:
> 
> > On Oct 10, 2018, at 2:03 AM, Raslan Darawsheh <rasland at mellanox.com> wrote:
> > 
> > Signed-off-by: Raslan Darawsheh <rasland at mellanox.com>
> 
> This title for the patch is the what we did not why we did it, should that be changed? To me it does not convey the reason or we would need to add a more complete comment body text to explain why we wanted the change. It is a bit of nit picking.

I think the question "why" must be answered in the body.





More information about the dev mailing list