[dpdk-dev] [PATCH v5 1/3] net/tap: add queue and port ids in Rx/Tx queues structures

Raslan Darawsheh rasland at mellanox.com
Wed Oct 10 16:40:29 CEST 2018


Hi,

Just sent a new version with the commit log reworded to answer the "why" question you mentioned.
Thx for your reviews.

Kindest regards,
Raslan Darawsheh

> -----Original Message-----
> From: Thomas Monjalon <thomas at monjalon.net>
> Sent: Wednesday, October 10, 2018 5:08 PM
> To: Wiles, Keith <keith.wiles at intel.com>; Raslan Darawsheh
> <rasland at mellanox.com>
> Cc: dev at dpdk.org; Shahaf Shuler <shahafs at mellanox.com>; Ori Kam
> <orika at mellanox.com>; Yigit, Ferruh <ferruh.yigit at intel.com>
> Subject: Re: [PATCH v5 1/3] net/tap: add queue and port ids in Rx/Tx queues
> structures
> 
> 10/10/2018 14:50, Wiles, Keith:
> >
> > > On Oct 10, 2018, at 2:03 AM, Raslan Darawsheh <rasland at mellanox.com>
> wrote:
> > >
> > > Signed-off-by: Raslan Darawsheh <rasland at mellanox.com>
> >
> > This title for the patch is the what we did not why we did it, should that be
> changed? To me it does not convey the reason or we would need to add a
> more complete comment body text to explain why we wanted the change. It
> is a bit of nit picking.
> 
> I think the question "why" must be answered in the body.
> 
> 



More information about the dev mailing list