[dpdk-dev] [PATCH v2 00/10] experimental tags fixes

[Ferruh Yigit]

On 6/29/2019 6:06 PM, Thomas Monjalon wrote:
> 29/06/2019 13:58, David Marchand:
>> Following the build error reported by Aaron [1], I noticed that some
>> experimental functions could go unnoticed because of a gcc peculiarity.
>>
>> To catch those, I went and added a new check on the object files to
>> ensure that any experimental api flagged in the map files is really
>> exported as such.
>>
>> Then went with my previous idea of only adding the tags on the functions
>> prototypes and enforcing it (a new check in checkpatches.sh).
>> And finally enforcing that the __rte_experimental tag is always the first
>> part of a function prototype which seems to work with both gcc and clang.
> 
> Applied, thanks
> 


Getting an odd build error with "i686-native-linuxapp-icc" [1].
Beware of the "." at the end: "rte_flow_conv."

Objdump shows two symbols with one "." at the end and one without it [2].

And this seems not the problem of only experimental APIs [3]. But this is only
happening with "i686-native-linuxapp-icc".

Do you have any idea what is going on here?



[1]
Building i686-native-linuxapp-icc ...
rte_flow_conv. is flagged as experimental
but is not listed in version map
Please add rte_flow_conv. to the version map

rte_eth_dev_is_removed. is flagged as experimental
but is not listed in version map
Please add rte_eth_dev_is_removed. to the version map




[2]
$ objdump -x -j '.text.experimental' ./build/build/lib/librte_ethdev/rte_ethdev.o

./build/build/lib/librte_ethdev/rte_ethdev.o:     file format elf32-i386
./build/build/lib/librte_ethdev/rte_ethdev.o
architecture: i386, flags 0x00000011:
HAS_RELOC, HAS_SYMS
start address 0x00000000

Sections:
Idx Name          Size      VMA       LMA       File off  Algn
  4 .text.experimental 00001b70  00000000  00000000  0000e17d  2**4
                  CONTENTS, ALLOC, LOAD, RELOC, READONLY, CODE
SYMBOL TABLE:
00000000 l    d  .text.experimental     00000000 .text.experimental
00000000 g     F .text.experimental     00000090 rte_eth_find_next_of
00000090 g     F .text.experimental     000000d0 rte_eth_find_next_sibling
00000160 g     F .text.experimental     00000110 rte_eth_dev_owner_new
00000270 g     F .text.experimental     00000240 rte_eth_dev_owner_set
000004b0 g     F .text.experimental     000002c0 rte_eth_dev_owner_unset
00000770 g     F .text.experimental     000001b0 rte_eth_dev_owner_delete
00000920 g     F .text.experimental     00000190 rte_eth_dev_owner_get
00000ab0 g     F .text.experimental     000000e0 rte_eth_dev_rx_intr_ctl_q_get_fd
00000b90 g     F .text.experimental     000007d0 rte_eth_dev_create
00001360 g     F .text.experimental     000003a0 rte_eth_dev_destroy
00001700 g     F .text.experimental     000000e0 rte_eth_read_clock
000017e0 g     F .text.experimental     00000070 rte_eth_dev_get_module_info
00001850 g     F .text.experimental     00000070 rte_eth_dev_get_module_eeprom
000018c0 g     F .text.experimental     00000040 rte_eth_switch_domain_alloc
00001900 g     F .text.experimental     00000040 rte_eth_switch_domain_free
00001940 g     F .text.experimental     000001a0 rte_eth_devargs_parse
00001ae0 g     F .text.experimental     00000005 rte_eth_dev_is_removed
00001ae5 g     F .text.experimental     0000008b rte_eth_dev_is_removed.




[3]
objdump -x  ./build/build/lib/librte_ethdev/rte_ethdev.o | grep '\.$'
00002075 g     F .text  0000006b rte_eth_promiscuous_enable.
000020e5 g     F .text  0000005b rte_eth_promiscuous_get.
00002145 g     F .text  0000006b rte_eth_promiscuous_disable.
000021b5 g     F .text  0000006b rte_eth_allmulticast_enable.
00002225 g     F .text  0000005b rte_eth_allmulticast_get.
00002285 g     F .text  0000006b rte_eth_allmulticast_disable.
0000458d g     F .text  00000bc3 rte_eth_xstats_get_names_by_id.
00008109 g     F .text  00000147 rte_eth_dev_info_get.
00001ae5 g     F .text.experimental     0000008b rte_eth_dev_is_removed.
000043cf R_386_PC32        rte_eth_xstats_get_names_by_id.
00004406 R_386_PC32        rte_eth_xstats_get_names_by_id.