[dpdk-dev] [PATCH v2 00/10] experimental tags fixes

David Marchand david.marchand at redhat.com
Mon Jul 1 16:36:41 CEST 2019


On Mon, Jul 1, 2019 at 4:15 PM Ferruh Yigit <ferruh.yigit at intel.com> wrote:

> On 6/29/2019 6:06 PM, Thomas Monjalon wrote:
> > 29/06/2019 13:58, David Marchand:
> >> Following the build error reported by Aaron [1], I noticed that some
> >> experimental functions could go unnoticed because of a gcc peculiarity.
> >>
> >> To catch those, I went and added a new check on the object files to
> >> ensure that any experimental api flagged in the map files is really
> >> exported as such.
> >>
> >> Then went with my previous idea of only adding the tags on the functions
> >> prototypes and enforcing it (a new check in checkpatches.sh).
> >> And finally enforcing that the __rte_experimental tag is always the
> first
> >> part of a function prototype which seems to work with both gcc and
> clang.
> >
> > Applied, thanks
> >
>
>
> Getting an odd build error with "i686-native-linuxapp-icc" [1].
> Beware of the "." at the end: "rte_flow_conv."
>
> Objdump shows two symbols with one "." at the end and one without it [2].
>
> And this seems not the problem of only experimental APIs [3]. But this is
> only
> happening with "i686-native-linuxapp-icc".
>
> Do you have any idea what is going on here?
>
>
Looked at rte_flow_conv, and I can not see anything special about it.

There might be a subtility in the way symbol names are chosen by ICC.
Can ICC guys look at this and give us some enlightment?


-- 
David Marchand


More information about the dev mailing list