[dpdk-dev] [PATCH v8] app/pdump: add pudmp exits with primary support

Thomas Monjalon thomas at monjalon.net
Sat May 4 23:17:11 CEST 2019


Hi,

03/05/2019 07:48, Suanming. Mou:
> When primary app exits, the residual running pdump will stop the
> primary app to restart. Add pdump exits with primary support.

Sorry I fail to parse this sentence.
Maybe it should be longer to be more explicit about
what it the current issue and how it is solved.
Some comments in the code may also be improved.

> Signed-off-by: Suanming.Mou <mousuanming at huawei.com>

I think you should remove the dot in your name.

> Reviewed-by: Anatoly Burakov <anatoly.burakov at intel.com>
> Reviewed-by: Vipin Varghese <vipin.varghese at intel.com>
> ---
> V8:
> * reword the print info in monitor_primary.
> * add release_19_05.rst update.

As it is not a fix, it will slip in 19.08.





More information about the dev mailing list