[dpdk-dev] [PATCH v8] app/pdump: add pudmp exits with primary support

Suanming.Mou mousuanming at huawei.com
Sun May 5 03:20:54 CEST 2019

On 2019/5/5 5:17, Thomas Monjalon wrote:
> Hi,
> 03/05/2019 07:48, Suanming. Mou:
>> When primary app exits, the residual running pdump will stop the
>> primary app to restart. Add pdump exits with primary support.
> Sorry I fail to parse this sentence.
> Maybe it should be longer to be more explicit about
> what it the current issue and how it is solved.
Thanks for the suggestion. It's fine to add more contents.
> Some comments in the code may also be improved.

Could you please help to show the detail? Or it will be hard to do the 

` There are a thousand Hamlets in a thousand people's eyes.`

>> Signed-off-by: Suanming.Mou <mousuanming at huawei.com>
> I think you should remove the dot in your name.

Sorry for that, maybe I missed some important instructions which notes 
the dot.

I will remove it later.

>> Reviewed-by: Anatoly Burakov <anatoly.burakov at intel.com>
>> Reviewed-by: Vipin Varghese <vipin.varghese at intel.com>
>> ---
>> V8:
>> * reword the print info in monitor_primary.
>> * add release_19_05.rst update.
> As it is not a fix, it will slip in 19.08.

It seems 19.08 is still not started yet.

Does that mean the patch should be hung till 19.08 be started?


More information about the dev mailing list