[dpdk-dev] [PATCH] common/dpaax: fix i686 compilation issue
Shreyansh Jain
shreyansh.jain at nxp.com
Wed May 29 08:47:16 CEST 2019
Meson build on i686, part of DPDK CI, reports: (example report [1])
*Meson Failed Build #1:
OS: UB1604-32
Target: i686-native-linuxapp-gcc
../drivers/common/dpaax/dpaax_iova_table.c:121:3: note: in expansion of
macro ‘DPAAX_DEBUG’
DPAAX_DEBUG("Invalid memory node values or count. (size=%lu)",
^
'statbuf.st_size', part of fstat() is a 'off_t' - which should be printable
as '%lu'. But, only a particularly old compiler reports this (5.4.0).
For now, removing the variable being dumped as part of debug.
[1] http://mails.dpdk.org/archives/test-report/2019-May/082622.html
Fixes: 2f3d633aa593 ("common/dpaax: add library for PA/VA translation table")
Cc: shreyansh.jain at nxp.com
Signed-off-by: Shreyansh Jain <shreyansh.jain at nxp.com>
---
Note:
- Another option was to use the PRIu32 macros but, in absence of a proper
verification environment, I wish to take the safer route. In future, if
need arises, the field would be added to debug logs.
drivers/common/dpaax/dpaax_iova_table.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/common/dpaax/dpaax_iova_table.c b/drivers/common/dpaax/dpaax_iova_table.c
index 2dd38a920..4ba38ac00 100644
--- a/drivers/common/dpaax/dpaax_iova_table.c
+++ b/drivers/common/dpaax/dpaax_iova_table.c
@@ -118,8 +118,7 @@ read_memory_node(unsigned int *count)
*/
*count = (statbuf.st_size / 16);
if ((*count) <= 0 || (statbuf.st_size % 16 != 0)) {
- DPAAX_DEBUG("Invalid memory node values or count. (size=%lu)",
- statbuf.st_size);
+ DPAAX_DEBUG("Invalid memory node values or count. ");
goto cleanup;
}
--
2.17.1
More information about the dev
mailing list