[dpdk-dev] [PATCH] common/dpaax: fix i686 compilation issue

[Bruce Richardson]

On Wed, May 29, 2019 at 12:17:16PM +0530, Shreyansh Jain wrote:
> Meson build on i686, part of DPDK CI, reports: (example report [1])
>     *Meson Failed Build #1:
>     OS: UB1604-32
>     Target: i686-native-linuxapp-gcc
>     ../drivers/common/dpaax/dpaax_iova_table.c:121:3: note: in expansion of
>     macro ‘DPAAX_DEBUG’
>        DPAAX_DEBUG("Invalid memory node values or count. (size=%lu)",
>        ^
> 
> 'statbuf.st_size', part of fstat() is a 'off_t' - which should be printable
> as '%lu'. But, only a particularly old compiler reports this (5.4.0).
> For now, removing the variable being dumped as part of debug.
> 
> [1] http://mails.dpdk.org/archives/test-report/2019-May/082622.html
> 
> Fixes: 2f3d633aa593 ("common/dpaax: add library for PA/VA translation table")
> Cc: shreyansh.jain at nxp.com
> 
> Signed-off-by: Shreyansh Jain <shreyansh.jain at nxp.com>
> ---
> Note:
>  - Another option was to use the PRIu32 macros but, in absence of a proper
>    verification environment, I wish to take the safer route. In future, if
>    need arises, the field would be added to debug logs.
> 
Actually, I think it's a bit more complicated than that, since for meson
and make builds, the type and size of the offset field varies. I've already
posted a fix for this and other 32-bit build issues. Please review that, and
let me know what you think.

Ref: http://patches.dpdk.org/patch/53728/ <Fix for DPAA driver>
Ref: http://patches.dpdk.org/project/dpdk/list/?series=4792 <Full series>

Regards,
/Bruce