[dpdk-dev] [PATCH 2/3] drivers: use RTE_DIM instead of ARRAY_SIZE

Igor Russkikh Igor.Russkikh at aquantia.com
Fri Oct 11 11:03:39 CEST 2019



> 
> [snip]
> 
>>   drivers/net/sfc/base/ef10_ev.c                |  4 +--
>>   drivers/net/sfc/base/ef10_filter.c            | 12 ++++----
>>   drivers/net/sfc/base/ef10_mac.c               | 18 +++++------
>>   drivers/net/sfc/base/ef10_nic.c               |  4 +--
>>   drivers/net/sfc/base/ef10_nvram.c             |  6 ++--
>>   drivers/net/sfc/base/efx.h                    |  3 --
>>   drivers/net/sfc/base/efx_port.c               |  2 +-
>>   drivers/net/sfc/base/efx_rx.c                 |  2 +-
>>   drivers/net/sfc/base/siena_mac.c              |  2 +-
>>   drivers/net/sfc/base/siena_nic.c              | 20 ++++++-------
>>   drivers/net/sfc/base/siena_nvram.c            |  6 ++--
> 
> NACK
> No changes in net/sfc/base please. It is the base driver
> which is used on other platforms. So, it can't use DPDK
> specific macros.
> 

Hi Pravan,

> 
>  drivers/net/atlantic/atl_hw_regs.h            |  1 -
>  drivers/net/atlantic/hw_atl/hw_atl_utils.c    |  4 +--
>  .../net/atlantic/hw_atl/hw_atl_utils_fw2x.c   |  2 +-

We also tend to share these modules with linux and other codebases.
Less diffs we have to review is better.
Why not keep ARRAY_SIZE as a widely used compat alternative?

Regards,
  Igor


More information about the dev mailing list