[dpdk-dev] [PATCH 2/3] drivers: use RTE_DIM instead of ARRAY_SIZE
Hyong Youb Kim (hyonkim)
hyonkim at cisco.com
Fri Oct 11 11:00:56 CEST 2019
> -----Original Message-----
> From: pbhagavatula at marvell.com <pbhagavatula at marvell.com>
> Sent: Friday, October 11, 2019 1:07 PM
[...]
> Subject: [dpdk-dev] [PATCH 2/3] drivers: use RTE_DIM instead of
> ARRAY_SIZE
>
> From: Pavan Nikhilesh <pbhagavatula at marvell.com>
>
> Use RTE_DIM instead of re-defining ARRAY_SIZE.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula at marvell.com>
> ---
[...]
> drivers/net/enic/base/vnic_dev.c | 4 +--
> drivers/net/enic/base/vnic_devcmd.h | 2 --
[...]
> diff --git a/drivers/net/enic/base/vnic_dev.c
> b/drivers/net/enic/base/vnic_dev.c
> index 8e190687d..3b9a336ff 100644
> --- a/drivers/net/enic/base/vnic_dev.c
> +++ b/drivers/net/enic/base/vnic_dev.c
> @@ -417,11 +417,11 @@ int vnic_dev_cmd(struct vnic_dev *vdev, enum
> vnic_devcmd_cmd cmd,
> switch (vdev->proxy) {
> case PROXY_BY_INDEX:
> err = vnic_dev_cmd_proxy(vdev, CMD_PROXY_BY_INDEX,
> cmd,
> - args, ARRAY_SIZE(args), wait);
> + args, RTE_DIM(args), wait);
> break;
> case PROXY_BY_BDF:
> err = vnic_dev_cmd_proxy(vdev, CMD_PROXY_BY_BDF,
> cmd,
> - args, ARRAY_SIZE(args), wait);
> + args, RTE_DIM(args), wait);
> break;
> case PROXY_NONE:
> default:
> diff --git a/drivers/net/enic/base/vnic_devcmd.h
> b/drivers/net/enic/base/vnic_devcmd.h
> index fffe307e0..5a4f48106 100644
> --- a/drivers/net/enic/base/vnic_devcmd.h
> +++ b/drivers/net/enic/base/vnic_devcmd.h
> @@ -63,8 +63,6 @@
> #define _CMD_VTYPE(cmd) (((cmd) >> _CMD_VTYPESHIFT) &
> _CMD_VTYPEMASK)
> #define _CMD_N(cmd) (((cmd) >> _CMD_NSHIFT) & _CMD_NMASK)
>
> -#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
> -
> enum vnic_devcmd_cmd {
> CMD_NONE = _CMDC(_CMD_DIR_NONE,
> _CMD_VTYPE_NONE, 0),
>
[...]
For enic.
Acked-by: Hyong Youb Kim <hyonkim at cisco.com>
Thanks.
-Hyong
More information about the dev
mailing list