[dpdk-dev] [PATCH 2/3] drivers: use RTE_DIM instead of ARRAY_SIZE
Pavan Nikhilesh Bhagavatula
pbhagavatula at marvell.com
Mon Oct 14 08:58:20 CEST 2019
>-----Original Message-----
>From: Ferruh Yigit <ferruh.yigit at intel.com>
>Sent: Friday, October 11, 2019 7:18 PM
>To: Ananyev, Konstantin <konstantin.ananyev at intel.com>; Hemant
>Agrawal <hemant.agrawal at nxp.com>; Pavan Nikhilesh Bhagavatula
><pbhagavatula at marvell.com>; Sachin Saxena
><sachin.saxena at nxp.com>; Akhil Goyal <akhil.goyal at nxp.com>; Igor
>Russkikh <igor.russkikh at aquantia.com>; Pavel Belous
><pavel.belous at aquantia.com>; Ravi Kumar <ravi1.kumar at amd.com>;
>Rasesh Mody <rmody at marvell.com>; Shahed Shaikh
><shshaikh at marvell.com>; Rahul Lakkireddy
><rahul.lakkireddy at chelsio.com>; Marcin Wojtas <mw at semihalf.com>;
>Michal Krawczyk <mk at semihalf.com>; Guy Tzalik
><gtzalik at amazon.com>; Evgeny Schemeilin <evgenys at amazon.com>;
>Igor Chauskin <igorch at amazon.com>; John Daley
><johndale at cisco.com>; Hyong Youb Kim <hyonkim at cisco.com>; Wei
>Hu (Xavier) <xavier.huwei at huawei.com>; Min Hu (Connor)
><humin29 at huawei.com>; Yisen Zhuang <yisen.zhuang at huawei.com>;
>Xing, Beilei <beilei.xing at intel.com>; Zhang, Qi Z
><qi.z.zhang at intel.com>; Wu, Jingjing <jingjing.wu at intel.com>; Lu,
>Wenzhuo <wenzhuo.lu at intel.com>; Yang, Qiming
><qiming.yang at intel.com>; Alejandro Lucero
><alejandro.lucero at netronome.com>; Andrew Rybchenko
><arybchenko at solarflare.com>; Jerin Jacob Kollanukkaran
><jerinj at marvell.com>; Maciej Czekaj <mczekaj at marvell.com>; Xu,
>Rosen <rosen.xu at intel.com>; Zhang, Tianfei
><tianfei.zhang at intel.com>
>Cc: dev at dpdk.org
>Subject: Re: [dpdk-dev] [PATCH 2/3] drivers: use RTE_DIM instead
>of ARRAY_SIZE
>On 10/11/2019 10:32 AM, Ananyev, Konstantin wrote:
>>
>>
>>> Hi Pavan,
>>>
>>>>
>>>> From: Pavan Nikhilesh <pbhagavatula at marvell.com>
>>>>
>>>> Use RTE_DIM instead of re-defining ARRAY_SIZE.
>>>>
>>>> Signed-off-by: Pavan Nikhilesh <pbhagavatula at marvell.com>
>>>> ---
>>>> drivers/bus/dpaa/base/qbman/qman.c | 6 ++--
>>>> drivers/bus/dpaa/include/compat.h | 5 ----
>>>> drivers/crypto/dpaa2_sec/hw/compat.h | 8 -----
>>>> drivers/crypto/dpaa2_sec/hw/rta/jump_cmd.h | 6 ++--
>>>> drivers/crypto/dpaa2_sec/hw/rta/nfifo_cmd.h | 2 +-
>>>> drivers/net/atlantic/atl_hw_regs.h | 1 -
>>>> drivers/net/atlantic/hw_atl/hw_atl_utils.c | 4 +--
>>>> .../net/atlantic/hw_atl/hw_atl_utils_fw2x.c | 2 +-
>>>> drivers/net/axgbe/axgbe_common.h | 3 --
>>>> drivers/net/axgbe/axgbe_dev.c | 2 +-
>>>> drivers/net/bnx2x/bnx2x.c | 6 ++--
>>>> drivers/net/bnx2x/bnx2x.h | 6 ----
>>>> drivers/net/bnx2x/ecore_init.h | 8 ++---
>>>> drivers/net/bnx2x/ecore_sp.c | 2 +-
>>>> drivers/net/bnx2x/elink.c | 14 ++++-----
>>>> drivers/net/bnx2x/elink.h | 1 -
>>>> drivers/net/cxgbe/base/t4_hw.c | 16 +++++-----
>>>> drivers/net/cxgbe/base/t4vf_hw.c | 4 +--
>>>> drivers/net/cxgbe/cxgbe_compat.h | 2 --
>>>> drivers/net/cxgbe/cxgbe_flow.c | 4 +--
>>>> drivers/net/cxgbe/cxgbe_main.c | 10 +++----
>>>> drivers/net/cxgbe/sge.c | 2 +-
>>>> drivers/net/ena/ena_ethdev.c | 8 ++---
>>>> drivers/net/enic/base/vnic_dev.c | 4 +--
>>>> drivers/net/enic/base/vnic_devcmd.h | 2 --
>>>> drivers/net/hns3/hns3_cmd.c | 2 +-
>>>> drivers/net/hns3/hns3_ethdev.h | 2 --
>>>> drivers/net/hns3/hns3_flow.c | 18 +++++------
>>>> drivers/net/i40e/base/i40e_diag.c | 2 +-
>>>> drivers/net/i40e/base/i40e_osdep.h | 2 --
>>>> drivers/net/iavf/base/iavf_osdep.h | 2 --
>>>> drivers/net/ice/base/ice_fdir.c | 2 +-
>>>> drivers/net/ice/base/ice_flex_pipe.c | 2 +-
>>>> drivers/net/ice/base/ice_flow.c | 2 +-
>>>> drivers/net/ice/base/ice_osdep.h | 1 -
>>>> drivers/net/ice/base/ice_switch.c | 2 +-
>>>> .../net/nfp/nfpcore/nfp-common/nfp_platform.h | 4 ---
>>>> drivers/net/nfp/nfpcore/nfp_cppcore.c | 2 +-
>>>> drivers/net/nfp/nfpcore/nfp_nsp.c | 2 +-
>>>> drivers/net/nfp/nfpcore/nfp_nsp_eth.c | 4 +--
>>>> drivers/net/sfc/base/ef10_ev.c | 4 +--
>>>> drivers/net/sfc/base/ef10_filter.c | 12 ++++----
>>>> drivers/net/sfc/base/ef10_mac.c | 18 +++++------
>>>> drivers/net/sfc/base/ef10_nic.c | 4 +--
>>>> drivers/net/sfc/base/ef10_nvram.c | 6 ++--
>>>> drivers/net/sfc/base/efx.h | 3 --
>>>> drivers/net/sfc/base/efx_port.c | 2 +-
>>>> drivers/net/sfc/base/efx_rx.c | 2 +-
>>>> drivers/net/sfc/base/siena_mac.c | 2 +-
>>>> drivers/net/sfc/base/siena_nic.c | 20 ++++++-------
>>>> drivers/net/sfc/base/siena_nvram.c | 6 ++--
>>>> drivers/net/thunderx/base/nicvf_hw.c | 30 +++++++++--------
>--
>>>> drivers/net/thunderx/base/nicvf_hw.h | 2 --
>>>> .../raw/ifpga/base/osdep_rte/osdep_generic.h | 2 --
>>>> 54 files changed, 120 insertions(+), 170 deletions(-)
>>>>
>>>> diff --git a/drivers/bus/dpaa/base/qbman/qman.c
>>>> b/drivers/bus/dpaa/base/qbman/qman.c
>>>> index e43fc65ef..019be95e2 100644
>>>> --- a/drivers/bus/dpaa/base/qbman/qman.c
>>>> +++ b/drivers/bus/dpaa/base/qbman/qman.c
>>>> @@ -1956,7 +1956,7 @@ int qman_query_wq(u8
>query_dedicated, struct
>>>> qm_mcr_querywq *wq)
>>>> int i, array_len;
>>>>
>>>> wq->channel.id = be16_to_cpu(mcr-
>>querywq.channel.id);
>>>> - array_len = ARRAY_SIZE(mcr->querywq.wq_len);
>>>> + array_len = RTE_DIM(mcr->querywq.wq_len);
>>>
>>> [Hemant] some of these files are common Flibs and they are shared
>with other projects (Linux/uboot) etc. It will be more appropriate to
>>> map the ARRAY_SIZE to RTE_DIM in compat.h instead of changing
>this code inline.
>>> This way we need not to maintain diff from the common HW lib
>codes.
>>
>> +1 to this suggestion
>>
>
>What about dropping the drivers patch form this patchset but continue
>with others?
I will drop the drivers patch from this patchset and send v2 for the rest.
Pavan.
More information about the dev
mailing list