[dpdk-dev] [PATCH v2 20/37] doc: remove references to make in bbdev guides

Chautru, Nicolas nicolas.chautru at intel.com
Fri Aug 21 04:12:35 CEST 2020


> From: Power, Ciara <ciara.power at intel.com>
> Make is no longer supported for compiling DPDK, references are now removed
> in the documentation.
> 
> Reviewed-by: Kevin Laatz <kevin.laatz at intel.com>
> Signed-off-by: Ciara Power <ciara.power at intel.com>
> ---
>  doc/guides/bbdevs/fpga_5gnr_fec.rst |  7 ++-----
> doc/guides/bbdevs/fpga_lte_fec.rst  |  7 ++-----
>  doc/guides/bbdevs/turbo_sw.rst      | 15 ---------------
>  3 files changed, 4 insertions(+), 25 deletions(-)
> 
> diff --git a/doc/guides/bbdevs/fpga_5gnr_fec.rst
> b/doc/guides/bbdevs/fpga_5gnr_fec.rst
> index 6760391e8c..8e00c4ef22 100644
> --- a/doc/guides/bbdevs/fpga_5gnr_fec.rst
> +++ b/doc/guides/bbdevs/fpga_5gnr_fec.rst
> @@ -51,10 +51,7 @@ FPGA 5GNR FEC does not support the following:
>  Installation
>  ------------
> 
> -Section 3 of the DPDK manual provides instructions on installing and compiling
> DPDK. The -default set of bbdev compile flags may be found in
> config/common_base, where for example -the flag to build the FPGA 5GNR FEC
> device, ``CONFIG_RTE_LIBRTE_PMD_BBDEV_FPGA_5GNR_FEC``,
> -is already set.
> +Section 3 of the DPDK manual provides instructions on installing and compiling
> DPDK.
> 
>  DPDK requires hugepages to be configured as detailed in section 2 of the DPDK
> manual.
>  The bbdev test application has been tested with a configuration 40 x 1GB
> hugepages. The @@ -94,7 +91,7 @@ the UIO driver by repeating this
> command for every function.
>  .. code-block:: console
> 
>    cd <dpdk-top-level-directory>
> -  insmod ./build/kmod/igb_uio.ko
> +  insmod ./<build_dir>/kernel/linux/igb_uio/igb_uio.ko

Hi, 
Should this more specific? What do you mean by <build_dir> here? Is this defined somewhere else explicitly in doc? 
In other commit (with the python script) the assumption is that meson will install under <dpdk-top-level-directory>/build directory with hard coded path, ie. not forcing to other location. 
Can you clarify so that we are comprehensive and avoid confusion? 
Thanks
Nic






More information about the dev mailing list