[dpdk-dev] [PATCH v2 20/37] doc: remove references to make in bbdev guides

Power, Ciara ciara.power at intel.com
Fri Aug 21 12:55:30 CEST 2020


Hi Nicolas,


>-----Original Message-----
>From: Chautru, Nicolas <nicolas.chautru at intel.com>
>Sent: Friday 21 August 2020 03:13
>To: Power, Ciara <ciara.power at intel.com>; dev at dpdk.org
>Cc: Mcnamara, John <john.mcnamara at intel.com>; Kovacevic, Marko
><marko.kovacevic at intel.com>
>Subject: RE: [PATCH v2 20/37] doc: remove references to make in bbdev
>guides
>
>> From: Power, Ciara <ciara.power at intel.com> Make is no longer supported
>> for compiling DPDK, references are now removed in the documentation.
>>
>> Reviewed-by: Kevin Laatz <kevin.laatz at intel.com>
>> Signed-off-by: Ciara Power <ciara.power at intel.com>
>> ---
>>  doc/guides/bbdevs/fpga_5gnr_fec.rst |  7 ++-----
>> doc/guides/bbdevs/fpga_lte_fec.rst  |  7 ++-----
>>  doc/guides/bbdevs/turbo_sw.rst      | 15 ---------------
>>  3 files changed, 4 insertions(+), 25 deletions(-)
>>
<snip>
>>    cd <dpdk-top-level-directory>
>> -  insmod ./build/kmod/igb_uio.ko
>> +  insmod ./<build_dir>/kernel/linux/igb_uio/igb_uio.ko
>
>Hi,
>Should this more specific? What do you mean by <build_dir> here? Is this
>defined somewhere else explicitly in doc?
>In other commit (with the python script) the assumption is that meson will
>install under <dpdk-top-level-directory>/build directory with hard coded path,
>ie. not forcing to other location.
>Can you clarify so that we are comprehensive and avoid confusion?
>Thanks
>Nic
>
>
>

The "<build_dir>" here represents the meson build folder, which is named by the user so can vary.
In the python script, I added "build" as the hardcoded path for the build folder, based on the example in the prog_guide/build-sdk-meson guide, which chooses to name the folder "build".

Thanks,
Ciara


More information about the dev mailing list