[dpdk-dev] [PATCH 0/8] net/ionic: minor updates and documentation

Ferruh Yigit ferruh.yigit at intel.com
Tue Nov 3 14:11:02 CET 2020


On 11/2/2020 6:35 PM, Andrew Boyer wrote:
> These patches make some minor changes to the ionic PMD. This is my first
> patch submission to DPDK, so please let me know if there is anything amiss.
> 
> Andrew Boyer (8):
>    ionic: update documentation and MAINTAINERS
>    ionic: connect to the meson build system
>    ionic: update ionic_if.h to the latest version
>    ionic: check for devcmd/admincmd completion more frequently
>    ionic: remove some unused fields
>    ionic: convert 'deferred' boolean to a flag bit
>    ionic: warn if RTE tries to enable loopback mode
>    ionic: nits - whitespace, logging, helper variables
> 

Hi Andrew,

Can you please use "net/ionic: " prefix for the patch titles.

Also please fix warnings of the following scripts:
./devtools/checkpatches.sh -n8
./devtools/check-git-log.sh -n8

checkpatch reports following typos, you need codespell to see them, I am pasting 
here for any case:

### ionic: update ionic_if.h to the latest version

WARNING:TYPO_SPELLING: 'Maximim' may be misspelled - perhaps 'Maximum'?
#355: FILE: drivers/net/ionic/ionic_if.h:404: 
 

+ *     @max_frame_size:     Maximim size of frames to be sent

WARNING:TYPO_SPELLING: 'tranceiver' may be misspelled - perhaps 'transceiver'?
#1158: FILE: drivers/net/ionic/ionic_if.h:1236:
+ * @xcvr:               tranceiver status

WARNING:TYPO_SPELLING: 'autonegotation' may be misspelled - perhaps 
'autonegotiation'?
#1219: FILE: drivers/net/ionic/ionic_if.h:1328:
+ * @IONIC_PORT_ATTR_AUTONEG:    Port autonegotation attribute


More information about the dev mailing list