[dpdk-dev] [PATCH 8/8] ionic: nits - whitespace, logging, helper variables

Ferruh Yigit ferruh.yigit at intel.com
Tue Nov 3 15:02:18 CET 2020


On 11/3/2020 2:00 PM, Andrew Boyer wrote:
> 
> 
>> On Nov 3, 2020, at 8:06 AM, Ferruh Yigit <ferruh.yigit at intel.com 
>> <mailto:ferruh.yigit at intel.com>> wrote:
>>
>> On 11/2/2020 6:35 PM, Andrew Boyer wrote:
>>> These are minor cleanups which did not deserve their own patches.
>>> Signed-off-by: Andrew Boyer <aboyer at pensando.io <mailto:aboyer at pensando.io>>
>>> ---
>>>  drivers/net/ionic/ionic_ethdev.c | 10 ++++------
>>>  drivers/net/ionic/ionic_lif.c    | 22 ++++++++++-----------
>>>  drivers/net/ionic/ionic_main.c   |  4 +---
>>>  drivers/net/ionic/ionic_rxtx.c   | 33 ++++++++++++++------------------
>>>  4 files changed, 29 insertions(+), 40 deletions(-)
> 
>>> ...
>>
>> As far as I can see this patchset has,
>> 1- minor fixes
>> 2- some code refactoring
>> 3- Whitespace updates
>>
>> Would you mind whitespace changes for now, and separate patch for 1 & 2?
> 
> Please clarify - looks like there’s a word missing?
> 

it is :)

Would you mind leaving/dropping the whitespace changes for now, and have two 
separate patches for 1 & 2?


More information about the dev mailing list