[dpdk-dev] [PATCH v5 15/20] doc: remove references to make from rawdevs guides

Bruce Richardson bruce.richardson at intel.com
Thu Oct 1 17:17:22 CEST 2020


On Mon, Sep 21, 2020 at 02:59:26PM +0100, Ciara Power wrote:
> Make is no longer supported for compiling DPDK, references are now
> removed in the documentation.
> 
> Signed-off-by: Ciara Power <ciara.power at intel.com>
> Reviewed-by: Kevin Laatz <kevin.laatz at intel.com>
> ---
>  doc/guides/rawdevs/dpaa2_cmdif.rst   | 21 ---------------------
>  doc/guides/rawdevs/dpaa2_qdma.rst    | 21 ---------------------
>  doc/guides/rawdevs/ifpga.rst         | 10 ----------
>  doc/guides/rawdevs/ioat.rst          |  8 +-------
>  doc/guides/rawdevs/ntb.rst           |  6 ------
>  doc/guides/rawdevs/octeontx2_dma.rst | 12 ------------
>  doc/guides/rawdevs/octeontx2_ep.rst  |  8 --------
>  7 files changed, 1 insertion(+), 85 deletions(-)
> 
<snip>
> diff --git a/doc/guides/rawdevs/ioat.rst b/doc/guides/rawdevs/ioat.rst
> index c46460ff45..b1b10c7fad 100644
> --- a/doc/guides/rawdevs/ioat.rst
> +++ b/doc/guides/rawdevs/ioat.rst
> @@ -54,13 +54,7 @@ shows:
>  Compilation
>  ------------
>  
> -For builds done with ``make``, the driver compilation is enabled by the
> -``CONFIG_RTE_LIBRTE_PMD_IOAT_RAWDEV`` build configuration option. This is
> -enabled by default in builds for x86 platforms, and disabled in other
> -configurations.
> -
> -For builds using ``meson`` and ``ninja``, the driver will be built when the
> -target platform is x86-based.
> +The driver will be built when the target platform is x86-based.
>  

This change for ioat is good, but the sentence now feels a little
incomplete. Can we perhaps just add on a bit to make it something like:

	"The driver will be enabled in the DPDK build when the target
	platform is x86-based; no additional build configuration steps
	are necessary."

Otherwise for the ioat part:

Acked-by: Bruce Richardson <bruce.richardson at intel.com>



More information about the dev mailing list