[dpdk-dev] [PATCH] eal/windows: fix incorrect free condition in getopt implementation

Dmitry Kozlyuk dmitry.kozliuk at gmail.com
Fri Sep 25 01:17:32 CEST 2020


On Wed, 23 Sep 2020 17:15:38 +0300, Tal Shnaiderman wrote:
> In the Windows getopt_internal function the condition freeing
> the memory allocated by _dupenv_s is correct only for the first
> call to the function.

Hi Tal,

a few days back Khoa To and me privately discussed a patch that makes MinGW
and Clang bith use getopt.c from librte_eal (now only Clang does). That patch
includes adjustments that just remove _dupenv_s() along with the bug. Just
discovered you were not Cc'd, sorry. I put your name in Reported-by and
mentioned the bug in commit message: http://patchwork.dpdk.org/patch/78765/


More information about the dev mailing list