[dpdk-dev] [PATCH] eal/windows: fix incorrect free condition in getopt implementation

Tal Shnaiderman talshn at nvidia.com
Fri Sep 25 18:59:38 CEST 2020


> From: Dmitry Kozlyuk <dmitry.kozliuk at gmail.com>
> On Wed, 23 Sep 2020 17:15:38 +0300, Tal Shnaiderman wrote:
> > In the Windows getopt_internal function the condition freeing the
> > memory allocated by _dupenv_s is correct only for the first call to
> > the function.
> 
> Hi Tal,
> 
> a few days back Khoa To and me privately discussed a patch that makes
> MinGW and Clang bith use getopt.c from librte_eal (now only Clang does).
> That patch includes adjustments that just remove _dupenv_s() along with
> the bug. Just discovered you were not Cc'd, sorry. I put your name in
> Reported-by and mentioned the bug in commit message:
> https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch
> work.dpdk.org%2Fpatch%2F78765%2F&data=02%7C01%7Ctalshn%40nvi
> dia.com%7Cab3a10f2d2ec458a7ef908d860e00e69%7C43083d15727340c1b7db
> 39efd9ccc17a%7C0%7C0%7C637365862717871619&sdata=1xiI9JZ%2BUw
> sv2mj8rkAcff6%2B3KFNYZUiM72ZbnkyokY%3D&reserved=0

Thanks for the update Dmitry, I'll mark this commit as superseded.


More information about the dev mailing list