[dpdk-dev] [PATCH 0/4] lpm lookupx4 fixes

Medvedkin, Vladimir vladimir.medvedkin at intel.com
Wed Jan 13 19:46:34 CET 2021


Hi Ruifeng,

LGTM, Thanks!

On 08/01/2021 08:21, Ruifeng Wang wrote:
> This series fixed bug in lpm4 vector lookup implementations.
> When more than 256 tbl8 groups are created, lookupx4 could
> retrieve next hop data from wrong group.
> The bug is there since next_hop field was expanded from
> 8-bit to 24-bit, and inherited by other implementations.
> 
> Also updated test case to improve coverage to detect such
> failure.
> 
> Ruifeng Wang (4):
>    lpm: fix vector lookup for Arm
>    lpm: fix vector lookup for x86
>    lpm: fix vector lookup for ppc64
>    test/lpm: improve coverage on tbl8
> 
>   app/test/test_lpm.c              | 22 ++++++++++++++--------
>   lib/librte_lpm/rte_lpm_altivec.h |  8 ++++----
>   lib/librte_lpm/rte_lpm_neon.h    |  8 ++++----
>   lib/librte_lpm/rte_lpm_sse.h     |  8 ++++----
>   4 files changed, 26 insertions(+), 20 deletions(-)
> 

Acked-by: Vladimir Medvedkin <vladimir.medvedkin at intel.com>

-- 
Regards,
Vladimir


More information about the dev mailing list