[dpdk-dev] [PATCH 0/4] lpm lookupx4 fixes

[Ruifeng Wang]

> -----Original Message-----
> From: David Marchand <david.marchand at redhat.com>
> Sent: Wednesday, January 13, 2021 10:53 PM
> To: Ruifeng Wang <Ruifeng.Wang at arm.com>; Vladimir Medvedkin
> <vladimir.medvedkin at intel.com>; Bruce Richardson
> <bruce.richardson at intel.com>
> Cc: dev <dev at dpdk.org>; nd <nd at arm.com>; jerinj at marvell.com; David
> Christensen <drc at linux.vnet.ibm.com>; Honnappa Nagarahalli
> <Honnappa.Nagarahalli at arm.com>
> Subject: Re: [dpdk-dev] [PATCH 0/4] lpm lookupx4 fixes
> 
> On Fri, Jan 8, 2021 at 9:22 AM Ruifeng Wang <ruifeng.wang at arm.com>
> wrote:
> >
> > This series fixed bug in lpm4 vector lookup implementations.
> > When more than 256 tbl8 groups are created, lookupx4 could retrieve
> > next hop data from wrong group.
> > The bug is there since next_hop field was expanded from 8-bit to
> > 24-bit, and inherited by other implementations.
> 
> This is a single issue: I would squash those 3 patches as a single patch (with 3
> Fixes: tags).

I split the patch for review purpose.
It is OK to squash them into a single one on merge.
Thank you.

> 
> >
> > Also updated test case to improve coverage to detect such failure.
> >
> > Ruifeng Wang (4):
> >   lpm: fix vector lookup for Arm
> >   lpm: fix vector lookup for x86
> >   lpm: fix vector lookup for ppc64
> >   test/lpm: improve coverage on tbl8
> 
> Reviews please?
> 
> 
> --
> David Marchand